Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/492
-gerrit
commit 3220062a8c6312889c98688c6cee0ced13e31dbf Author: Sven Schnelle svens@stackframe.org Date: Fri Dec 2 16:21:35 2011 +0100
Add Intel Socket LGA771
Change-Id: Iee7d3ff2884d8c43ff1af498160589e551bc9cc8 Signed-off-by: Sven Schnelle svens@stackframe.org --- src/cpu/intel/Kconfig | 1 + src/cpu/intel/Makefile.inc | 1 + src/cpu/intel/socket_LGA771/Kconfig | 7 +++++++ src/cpu/intel/socket_LGA771/Makefile.inc | 11 +++++++++++ src/cpu/intel/socket_LGA771/chip.h | 4 ++++ src/cpu/intel/socket_LGA771/socket_LGA771.c | 7 +++++++ 6 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/src/cpu/intel/Kconfig b/src/cpu/intel/Kconfig index 8cf30c9..31c701c 100644 --- a/src/cpu/intel/Kconfig +++ b/src/cpu/intel/Kconfig @@ -28,3 +28,4 @@ source src/cpu/intel/socket_mPGA603/Kconfig source src/cpu/intel/socket_mPGA604/Kconfig source src/cpu/intel/socket_PGA370/Kconfig source src/cpu/intel/socket_441/Kconfig +source src/cpu/intel/socket_LGA771/Kconfig diff --git a/src/cpu/intel/Makefile.inc b/src/cpu/intel/Makefile.inc index 93ab7de..274c101 100644 --- a/src/cpu/intel/Makefile.inc +++ b/src/cpu/intel/Makefile.inc @@ -16,6 +16,7 @@ subdirs-$(CONFIG_CPU_INTEL_SOCKET_MPGA604) += socket_mPGA604 subdirs-$(CONFIG_CPU_INTEL_SOCKET_PGA370) += socket_PGA370 subdirs-$(CONFIG_CPU_INTEL_SLOT_2) += slot_2 subdirs-$(CONFIG_CPU_INTEL_SLOT_1) += slot_1 +subdirs-$(CONFIG_CPU_INTEL_SOCKET_LGA771) += socket_LGA771
#socket_mPGA604_533Mhz #socket_mPGA604_800Mhz diff --git a/src/cpu/intel/socket_LGA771/Kconfig b/src/cpu/intel/socket_LGA771/Kconfig new file mode 100644 index 0000000..0821c3e --- /dev/null +++ b/src/cpu/intel/socket_LGA771/Kconfig @@ -0,0 +1,7 @@ +config CPU_INTEL_SOCKET_LGA771 + bool + select CPU_INTEL_MODEL_6FX + select CPU_INTEL_CORE2 + select SSE2 + select MMX + select AP_IN_SIPI_WAIT diff --git a/src/cpu/intel/socket_LGA771/Makefile.inc b/src/cpu/intel/socket_LGA771/Makefile.inc new file mode 100644 index 0000000..319430f --- /dev/null +++ b/src/cpu/intel/socket_LGA771/Makefile.inc @@ -0,0 +1,11 @@ +ramstage-y += socket_LGA771.c +subdirs-y += ../model_6ex +subdirs-y += ../model_6fx +subdirs-y += ../../x86/tsc +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/lapic +subdirs-y += ../../x86/cache +subdirs-y += ../../x86/smm +subdirs-y += ../microcode +subdirs-y += ../hyperthreading + diff --git a/src/cpu/intel/socket_LGA771/chip.h b/src/cpu/intel/socket_LGA771/chip.h new file mode 100644 index 0000000..d3f312e --- /dev/null +++ b/src/cpu/intel/socket_LGA771/chip.h @@ -0,0 +1,4 @@ +extern struct chip_operations cpu_intel_socket_LGA771_ops; + +struct cpu_intel_socket_LGA771_config { +}; diff --git a/src/cpu/intel/socket_LGA771/socket_LGA771.c b/src/cpu/intel/socket_LGA771/socket_LGA771.c new file mode 100644 index 0000000..21a7dc9 --- /dev/null +++ b/src/cpu/intel/socket_LGA771/socket_LGA771.c @@ -0,0 +1,7 @@ +#include <device/device.h> +#include "chip.h" + + +struct chip_operations cpu_intel_socket_LGA771_ops = { + CHIP_NAME("Socket LGA771 CPU") +};
Repost to the list, apologies.
Thanks! that will be useful as a template for adding the LGA775 socket.
My CPUs are of the Pentium E5x00 kind, that is Pentium Dual Core based on the Enhanced Core microarchitecture.
The problem is the family is 06 and model 17 (hexadecimals), not directly compatible with the model_xx convention used so far. I don't know how deep is going this convention into coreboot.
Looking at the latest Intel documentation (e.g. 64-ia-32-architectures-software-developer-vol-3b-part-2-manual, october 2011), the CPU microarchitecture main identification is a DisplayFamilyDisplayModel string of the form xx_xxH, x being an hexadecimal digit. I suggest to keep by that convention for the Intel CPUs, something like model_xx_xxH and not model_xx. To make the switch easy, just make model_xx a symlink to model_xx_xxH. Looking for info on a given CPU in Intel doc would be easier.
Comments welcome.
nap
Le 17/12/2011 19:42, Sven Schnelle (svens@stackframe.org) a écrit :
Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/492
-gerrit
commit 3220062a8c6312889c98688c6cee0ced13e31dbf Author: Sven Schnelle svens@stackframe.org Date: Fri Dec 2 16:21:35 2011 +0100
Add Intel Socket LGA771 Change-Id: Iee7d3ff2884d8c43ff1af498160589e551bc9cc8 Signed-off-by: Sven Schnelle <svens@stackframe.org>
src/cpu/intel/Kconfig | 1 + src/cpu/intel/Makefile.inc | 1 + src/cpu/intel/socket_LGA771/Kconfig | 7 +++++++ src/cpu/intel/socket_LGA771/Makefile.inc | 11 +++++++++++ src/cpu/intel/socket_LGA771/chip.h | 4 ++++ src/cpu/intel/socket_LGA771/socket_LGA771.c | 7 +++++++ 6 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/src/cpu/intel/Kconfig b/src/cpu/intel/Kconfig index 8cf30c9..31c701c 100644 --- a/src/cpu/intel/Kconfig +++ b/src/cpu/intel/Kconfig @@ -28,3 +28,4 @@ source src/cpu/intel/socket_mPGA603/Kconfig source src/cpu/intel/socket_mPGA604/Kconfig source src/cpu/intel/socket_PGA370/Kconfig source src/cpu/intel/socket_441/Kconfig +source src/cpu/intel/socket_LGA771/Kconfig diff --git a/src/cpu/intel/Makefile.inc b/src/cpu/intel/Makefile.inc index 93ab7de..274c101 100644 --- a/src/cpu/intel/Makefile.inc +++ b/src/cpu/intel/Makefile.inc @@ -16,6 +16,7 @@ subdirs-$(CONFIG_CPU_INTEL_SOCKET_MPGA604) += socket_mPGA604 subdirs-$(CONFIG_CPU_INTEL_SOCKET_PGA370) += socket_PGA370 subdirs-$(CONFIG_CPU_INTEL_SLOT_2) += slot_2 subdirs-$(CONFIG_CPU_INTEL_SLOT_1) += slot_1 +subdirs-$(CONFIG_CPU_INTEL_SOCKET_LGA771) += socket_LGA771
#socket_mPGA604_533Mhz #socket_mPGA604_800Mhz diff --git a/src/cpu/intel/socket_LGA771/Kconfig b/src/cpu/intel/socket_LGA771/Kconfig new file mode 100644 index 0000000..0821c3e --- /dev/null +++ b/src/cpu/intel/socket_LGA771/Kconfig @@ -0,0 +1,7 @@ +config CPU_INTEL_SOCKET_LGA771
- bool
select CPU_INTEL_MODEL_6FXselect CPU_INTEL_CORE2- select SSE2
- select MMX
- select AP_IN_SIPI_WAIT
diff --git a/src/cpu/intel/socket_LGA771/Makefile.inc b/src/cpu/intel/socket_LGA771/Makefile.inc
new file mode 10064 index 0000000..319430f --- /dev/null +++ b/src/cpu/intel/socket_LGA771/Makefile.inc @@ -0,0 +1,11 @@ +ramstage-y += socket_LGA771.c +subdirs-y += ../model_6ex +subdirs-y += ../model_6fx +subdirs-y += ../../x86/tsc +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/lapic +subdirs-y += ../../x86/cache +subdirs-y += ../../x86/smm +subdirs-y += ../microcode +subdirs-y += ../hyperthreading
diff --git a/src/cpu/intel/socket_LGA771/chip.h b/src/cpu/intel/socket_LGA771/chip.h new file mode 100644 index 0000000..d3f312e --- /dev/null +++ b/src/cpu/intel/socket_LGA771/chip.h @@ -0,0 +1,4 @@ +extern struct chip_operations cpu_intel_socket_LGA771_ops;
+struct cpu_intel_socket_LGA771_config { +}; diff --git a/src/cpu/intel/socket_LGA771/socket_LGA771.c b/src/cpu/intel/socket_LGA771/socket_LGA771.c new file mode 100644 index 0000000..21a7dc9 --- /dev/null +++ b/src/cpu/intel/socket_LGA771/socket_LGA771.c @@ -0,0 +1,7 @@ +#include <device/device.h> +#include "chip.h"
+struct chip_operations cpu_intel_socket_LGA771_ops = {
- CHIP_NAME("Socket LGA771 CPU")
+};
On Sun, Dec 18, 2011 at 1:04 AM, nap caracol@neuf.fr wrote:
The problem is the family is 06 and model 17 (hexadecimals), not directly compatible with the model_xx convention used so far. I don't know how deep is going this convention into coreboot.
it's a convention. If we can't take an arbitrary name then we've done something wrong.
just make model_xx a symlink to model_xx_xxH.
I don't see the need for a symlink. Just go with your proposed name.
thanks
ron
-
nap -
ron minnich -
Sven Schnelle