[PATCH] v2: sb600: Fix I/O port variable size, simplify code

[Uwe Hermann]

See patch.

Uwe.

[PATCH] v2: sb600: Fix I/O port variable size, simplify code

[Marc Jones]

Uwe Hermann wrote:
> See patch.
>
> Uwe.
> I/O ports are 16bit, so change 'unsigned long port_base' to 'u16 port_base'.
> Also, use more readable #defines instead of hardcoded config ports for
> PM/PM2 related functions, and simplify them a bit.
>
> Build-tested with the AMD dbm690t target.
>
> Signed-off-by: Uwe Hermann

Good stuff. Thanks!
Acked-by: Marc Jones

[Uwe Hermann]

On Tue, Oct 21, 2008 at 10:12:43AM -0600, Marc Jones wrote:
> > I/O ports are 16bit, so change 'unsigned long port_base' to 'u16 port_base'.
> > Also, use more readable #defines instead of hardcoded config ports for
> > PM/PM2 related functions, and simplify them a bit.
> >
> > Build-tested with the AMD dbm690t target.
> >
> > Signed-off-by: Uwe Hermann
>
> Good stuff. Thanks!
> Acked-by: Marc Jones

Thanks, r3680.

I'll also do the same in v3 soonish.

Uwe.

[PATCH] v2: sb600: Fix I/O port variable size, simplify code

[Carl-Daniel Hailfinger]

On 21.10.2008 18:33, Uwe Hermann wrote:
> On Tue, Oct 21, 2008 at 10:12:43AM -0600, Marc Jones wrote:
> > > I/O ports are 16bit, so change 'unsigned long port_base' to 'u16 port_base'.
> > > Also, use more readable #defines instead of hardcoded config ports for
> > > PM/PM2 related functions, and simplify them a bit.
> > >
> > > Build-tested with the AMD dbm690t target.
> > >
> > > Signed-off-by: Uwe Hermann
> >
> > Good stuff. Thanks!
> > Acked-by: Marc Jones
>
> Thanks, r3680.
>
> I'll also do the same in v3 soonish.

Cool, thanks!

Regards,
Carl-Daniel