New Defects reported by Coverity Scan for coreboot

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

30 new defect(s) introduced to coreboot found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 30 defect(s)

** CID 1287080:    (FORWARD_NULL)
/src/vendorcode/amd/agesa/f14/Proc/CPU/S3.c: 542 in SaveConditionalMsrDevice()
/src/vendorcode/amd/agesa/f12/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice()
/src/vendorcode/amd/agesa/f15/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice()
/src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice()
/src/vendorcode/amd/agesa/f16kb/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice()

________________________________________________________________________________________________________
*** CID 1287080:    (FORWARD_NULL)
/src/vendorcode/amd/agesa/f14/Proc/CPU/S3.c: 542 in SaveConditionalMsrDevice()
536       if (CallPoint == INIT_RESUME) {
537         MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
538       } else {
539         S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
540       }
541
> > > CID 1287080:    (FORWARD_NULL)
> > > Dereferencing null pointer "RegisterHdr".

542       for (i = 0; i < RegisterHdr->NumRegisters; i++) {
543         if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) &&
544             ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) {
545           if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) {
546             LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader);
547           } else {
/src/vendorcode/amd/agesa/f12/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice()
542       if (CallPoint == INIT_RESUME) {
543         MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
544       } else {
545         S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
546       }
547
> > > CID 1287080:    (FORWARD_NULL)
> > > Dereferencing null pointer "RegisterHdr".

548       for (i = 0; i < RegisterHdr->NumRegisters; i++) {
549         if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) &&
550             ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) {
551           if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) {
552             LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader);
553           } else {
/src/vendorcode/amd/agesa/f15/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice()
542       if (CallPoint == INIT_RESUME) {
543         MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
544       } else {
545         S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
546       }
547
> > > CID 1287080:    (FORWARD_NULL)
> > > Dereferencing null pointer "RegisterHdr".

548       for (i = 0; i < RegisterHdr->NumRegisters; i++) {
549         if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) &&
550             ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) {
551           if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) {
552             LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader);
553           } else {
/src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice()
541       if (CallPoint == INIT_RESUME) {
542         MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
543       } else {
544         S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
545       }
546
> > > CID 1287080:    (FORWARD_NULL)
> > > Dereferencing null pointer "RegisterHdr".

547       for (i = 0; i < RegisterHdr->NumRegisters; i++) {
548         if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) &&
549             ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) {
550           if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) {
551             LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader);
552           } else {
/src/vendorcode/amd/agesa/f16kb/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice()
541       if (CallPoint == INIT_RESUME) {
542         MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
543       } else {
544         S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader);
545       }
546
> > > CID 1287080:    (FORWARD_NULL)
> > > Dereferencing null pointer "RegisterHdr".

547       for (i = 0; i < RegisterHdr->NumRegisters; i++) {
548         if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) &&
549             ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) {
550           if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) {
551             LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader);
552           } else {

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/1016?tab=overview

To manage Coverity Scan email notifications for "[e-mail]", click https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&a... .