Re: [coreboot] patch to display ASRock E350M1 freq correctly

[Rudolf Marek]

Hi all,
> I'm not native speaker and sorry for my English.

Yep me too ;) But your doing OK we can understand what you wrote.
> Finally I think maybe I can fix it myself and start
> digging ACPI and source code.

I'm quite surprised that this is hardcoded. We used to have a functions
which place it there runtime depending on CPU model. I don't know
why it is hardcoded here. I think a proper fix would be to provide that runtime 
depending on CPU. Maybe AGESA has some infrastructure for that. Did not check so 
far.

Thanks
Rudolf

patch to display ASRock E350M1 freq correctly

[Marc Jones]

On Tue, Oct 4, 2011 at 1:38 AM, Rudolf Marek  wrote:
> Hi all,
> > I'm not native speaker and sorry for my English.
>
> Yep me too ;) But your doing OK we can understand what you wrote.
> > Finally I think maybe I can fix it myself and start
> > digging ACPI and source code.
>
> I'm quite surprised that this is hardcoded. We used to have a functions
> which place it there runtime depending on CPU model. I don't know
> why it is hardcoded here. I think a proper fix would be to provide that
> runtime depending on CPU. Maybe AGESA has some infrastructure for that. Did
> not check so far.
>
> Thanks
> Rudolf

This should be generated by the AMDInitLate call, which needs some
work in coreboot acpi/agesa wrappers. Feel free to check out the
tables that are generated and look at how they should be integrated.

Marc