Dear coreboot folks,
looking through `src/console/Kconfig` I noticed
if SOUTHBRIDGE_INTEL_BD82X6X && DEFAULT_CONSOLE_LOGLEVEL_8 # Only visible with the right southbridge and loglevel. config DEBUG_INTEL_ME bool "Verbose logging for Intel Management Engine" default n help Enable verbose logging for Intel Management Engine driver that is present on Intel 6-series chipsets. endif
which seems odd as currently other chipsets needing the Intel Management Engine were submitted.
$ git grep DEBUG_INTEL_ME src/Kconfig:config DEBUG_INTEL_ME src/southbridge/intel/bd82x6x/me.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/bd82x6x/me_8.x.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/fsp_bd82x6x/me.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/fsp_bd82x6x/me_8.x.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/ibexpeak/me.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/lynxpoint/me_9.x.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/lynxpoint/me_9.x.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/lynxpoint/me_9.x.c:#if CONFIG_DEBUG_INTEL_ME src/southbridge/intel/lynxpoint/me_9.x.c:#if CONFIG_DEBUG_INTEL_ME
I am unable to test this, so it would be great if somebody else could fix this.
Thanks,
Paul
On Wednesday, February 19, 2014 11:06:40 PM Paul Menzel wrote:
looking through `src/console/Kconfig` I noticed
You mean 'src/Kconfig' ?
if SOUTHBRIDGE_INTEL_BD82X6X && DEFAULT_CONSOLE_LOGLEVEL_8
This is a layering violation. We shouldn't have hardware-specific options in top-level Kconfig. This should be moved to southbridge Kconfig, and not depend on LOGLEVEL. Maybe we need to move ME handling to a common dir and handle the Kconfigs there.
which seems odd as currently other chipsets needing the Intel Management Engine were submitted.
$ git grep DEBUG_INTEL_ME [...]
Smells like copypasta. Yet another reason to consider unifying ME handling across southbridges.
I am unable to test this, so it would be great if somebody else could fix this.
I don't blame you for not owning and/or not wanting to own intel hardware.
Alex
On 26.02.2014 04:24, mrnuke wrote:
On Wednesday, February 19, 2014 11:06:40 PM Paul Menzel wrote:
looking through `src/console/Kconfig` I noticed
You mean 'src/Kconfig' ?
if SOUTHBRIDGE_INTEL_BD82X6X && DEFAULT_CONSOLE_LOGLEVEL_8This is a layering violation. We shouldn't have hardware-specific options in top-level Kconfig. This should be moved to southbridge Kconfig, and not depend on LOGLEVEL. Maybe we need to move ME handling to a common dir and handle the Kconfigs there.
which seems odd as currently other chipsets needing the Intel Management Engine were submitted.
$ git grep DEBUG_INTEL_ME [...]Smells like copypasta. Yet another reason to consider unifying ME handling across southbridges.
Don't. This particular code is a good example why it shouldn't be done. On Ibexpeak this code (extended status print) would timeout.
-
mrnuke -
Paul Menzel -
Vladimir 'φ-coder/phcoder' Serbinenko