Julius Werner wrote:
I'd also like the interface to be friendlier. What granularity is actually supported for the option? I doubt that it's single bytes?
Maybe make it decimal kb? The default value depends on ROM_SIZE, right?
I would very much prefer it to stay byte sized. This makes the Makefiles that use it easier to write
It's trivial to add another variable between the user interface and Makefile rules to turn the friendly value into what's convenient for the code.
and avoids confusion compared to the byte sized CONFIG_ROM_SIZE.
The big difference is that users never see the actual ROM_SIZE value.
They see a friendly list of common flash chip sizes, with the default being what ships with the particular board.
The actually supported granularity is anything that CBFS/cbfstool supports as an image size, which I think is in theory arbitrary down to individual bytes.
What are the common CBFS_SIZE values?
//Peter
It's trivial to add another variable between the user interface and Makefile rules to turn the friendly value into what's convenient for the code.
Yeah. But then again, we already agreed that this is a very rare-use expert option. I don't think it's worth adding yet more lines to the Kconfig file just to make it pretty to choose.
The actually supported granularity is anything that CBFS/cbfstool supports as an image size, which I think is in theory arbitrary down to individual bytes.
What are the common CBFS_SIZE values?
We're using 1MB for most (all?) of our boards, but that's really completely arbitrary. If you want to use this at all, you probably know exactly what kind of size you want it to be as well. I really don't see the point in expending effort to restrict this to some arbitrary bin size.
(I'd also like to add that we're already developing a half-finished feature in our tree right now that will reshuffle the whole image layout once again, making this option obsolete... so we might not want to spend too much effort polishing it.)
-
Julius Werner -
Peter Stuge