amd sb800 wrapper compile warning fix

[She, Kerry]

Hello,

This patch fix a AMD sb800 wrapper compile warning:

src/southbridge/amd/cimx_wrapper/sb800/late

call clear_ioapic but not include the prototype declare header file.

and remove some trivial blanks.

Signed-off-by Kerry She

Regards, 
Kerry She < [e-mail]>
Tel:  [phone] 
Mobile:  86 - 152 1018 2083

[Marc Jones]

On Sun, May 29, 2011 at 11:24 PM, She, Kerry  wrote:
> Hello,
>
> This patch fix a AMD sb800 wrapper compile warning:
>
> src/southbridge/amd/cimx_wrapper/sb800/late
>
> call clear_ioapic but not include the prototype declare header file.
>
> and remove some trivial blanks.
>
> Signed-off-by Kerry She

Acked-by: Marc Jones

[Peter Stuge]

She, Kerry wrote:
> This patch fix a AMD sb800 wrapper compile warning:
>
> src/southbridge/amd/cimx_wrapper/sb800/late
>
> call clear_ioapic but not include the prototype declare header file.
>
> and remove some trivial blanks.

I think it is very important to make whitespace changes in a patch of
it's own, so that there are no other changes. Please also consider if
changing the license text in the source code is neccessary. It may be
better to keep unneccessary whitespace in the license texts, rather
than having a commit which changes the license.

Anyway, isolating whitespace changes in separate commits allows to
work more efficiently with the commit history in the future, which is
sooner or later always neccessary.

Please also create one patch for each logical change, with the
respective commit messages. Having multiple patches makes the review
process much easier, and also helps significantly when working with
the commit history in the future.

Thanks

//Peter

[She, Kerry]

> -----Original Message-----
> From: [e-mail]

[mailto:[e-mail]]
> On Behalf Of Peter Stuge
> Sent: Wednesday, June 01, 2011 7:29 AM
> To: [e-mail]
> Subject: Re: [coreboot] amd sb800 wrapper compile warning fix
>
> She, Kerry wrote:
> > This patch fix a AMD sb800 wrapper compile warning:
> >
> > src/southbridge/amd/cimx_wrapper/sb800/late
> >
> > call clear_ioapic but not include the prototype declare header file.
> >
> > and remove some trivial blanks.
>
> I think it is very important to make whitespace changes in a patch of
> it's own, so that there are no other changes. Please also consider if
> changing the license text in the source code is neccessary. It may be
> better to keep unneccessary whitespace in the license texts, rather
> than having a commit which changes the license.

Removing the whitespace in the license text is not my intention.
I just use the script to remove all the whitespace when I found there is
some blank at the end of line in certain file.
> Anyway, isolating whitespace changes in separate commits allows to
> work more efficiently with the commit history in the future, which is
> sooner or later always neccessary.

Ok
> Please also create one patch for each logical change, with the
> respective commit messages. Having multiple patches makes the review
> process much easier, and also helps significantly when working with
> the commit history in the future.

Thanks for your advice

[Peter Stuge]

She, Kerry wrote:
> > I think it is very important to make whitespace changes in a patch of
> > it's own,

..
> Removing the whitespace in the license text is not my intention.

Understood. Changing the license text is certainly not forbidden,
especially since you work with the copyright holder, and sometimes
the license text *does* change, but maybe it is preferable to skip
whitespace fixes. It's also possible that I am just being too
careful about this.
> I just use the script to remove all the whitespace when I found there
> is some blank at the end of line in certain file.

This is a good idea! Maybe it will be possible to run the script
before sending future patches, so that no extra commits for fixes
are neccessary.

If you are using git for version control then it can also be
configured to colour code trailing whitespace when viewing changes
using git diff:

git config --global core.whitespace trailing-space,space-before-tab,-cr-at-eol
git config --global color.diff auto
> Thanks for your advice

Thank you for your continued work contributing to coreboot!

//Peter