[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Corey Osgood]

See attached patch. Thanks for all the great comments and suggestions!

-Corey

[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Joseph Smith]

Quoting Corey Osgood :
> See attached patch. Thanks for all the great comments and suggestions!
>
> -Corey

Am I alowed to Ack this? If so I ACK it :-)

Thanks - Joe

[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Peter Stuge]

On Wed, Jun 13, 2007 at 10:29:12PM -0400, Joseph Smith wrote:
> > See attached patch. Thanks for all the great comments and suggestions!
>
> Am I alowed to Ack this? If so I ACK it :-)

Sure you are, but please see the Development Guidelines on the wiki
for the formalia. http://linuxbios.org/Development_Guidelines

Sign-off Procedure and Review are particularly relevant.

//Peter

[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Joseph Smith]

Quoting Peter Stuge :
> On Wed, Jun 13, 2007 at 10:29:12PM -0400, Joseph Smith wrote:
> > > See attached patch. Thanks for all the great comments and suggestions!
> >
> > Am I alowed to Ack this? If so I ACK it :-)
>
> Sure you are, but please see the Development Guidelines on the wiki
> for the formalia. http://linuxbios.org/Development_Guidelines
>
> Sign-off Procedure and Review are particularly relevant.
>
> //Peter

Ok,
Acked-by: Joseph Smith

Thanks - Joe

[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Stefan Reinauer]

* Joseph Smith  [070614 05:41]:
> Ok,
> Acked-by: Joseph Smith

r2719

[LinuxBIOS] [PATCH] Fix previous patch for Asus MEW-VM

[Corey Osgood]

Stefan Reinauer wrote:
> Joseph Smith  [070614 05:41]:
> > Ok,
> > Acked-by: Joseph Smith
>
> r2719

Thanks guys. Somehow I let the i82810 slip by completely, and missed a
couple lines when I was manually editing the i82801. Attached patch
fixes those.

Signed-off-by: Corey Osgood

[LinuxBIOS] [PATCH] Fix previous patch for Asus MEW-VM

[Joseph Smith]

Quoting Corey Osgood :
> Stefan Reinauer wrote:
> > Joseph Smith  [070614 05:41]:
> > > Ok,
> > > Acked-by: Joseph Smith
> >
> > r2719
>
> Thanks guys. Somehow I let the i82810 slip by completely, and missed a
> couple lines when I was manually editing the i82801. Attached patch
> fixes those.
>
> Signed-off-by: Corey Osgood

Oh your right Corey, Oops. We should probibly get your patch commited  
asap right?

Acked-by: Joseph Smith

Thanks - Joe

[LinuxBIOS] [PATCH] Fix previous patch for Asus MEW-VM

[Uwe Hermann]

On Thu, Jun 14, 2007 at 04:36:05AM -0400, Joseph Smith wrote:
> > Thanks guys. Somehow I let the i82810 slip by completely, and missed a
> > couple lines when I was manually editing the i82801. Attached patch
> > fixes those.
> >
> > Signed-off-by: Corey Osgood

Committed in r2720 and r2721 with some minor changes, thanks!

One more thing I noticed in the 82810 code (but didn't fix, yet):

In spd_set_dram_size() the nesting level is quite deep (you notice
 immediately because the lines exceed 79 characters).

If you change

/* First check if a DIMM is actually present. */
        if (smbus_read_byte(ctrl->channel0[i], 2) == 4) {
    	// FOO
    } else {
    	// BAR
    }

to:

/* First check if a DIMM is actually present. */
        if (smbus_read_byte(ctrl->channel0[i], 2) != 4) {
    	// BAR
    	continue;	// or break? need to check.
    }

// FOO

that will make the code a lot more readable, IMO (FOO is a huge
  amount of code which needs to be indented quite a lot otherwise).
> Oh your right Corey, Oops. We should probibly get your patch commited  
> asap right?
>
> Acked-by: Joseph Smith

Did you review and/or test the patch? Acked-by is not merely a "I like it"
but should always involve at least some degree of review of the code
or even better testing the build and testing on real hardware (if possible).

Uwe.

[Uwe Hermann]

On Wed, Jun 13, 2007 at 05:23:46PM -0400, Corey Osgood wrote:
> See attached patch. Thanks for all the great comments and suggestions!

Really great work, thanks!

I added the stuff to the list of supported mainboards / northbridges, as
well as in a news item. Do you have a link to some website which shows
the specs of the ASUS MEW-VM? I can't seem to find something suitable,
at least not on the ASUS page.

Also, can you post a detailed report on what works and what doesn't so far?
And some more info on the board, lspci, lspci -vt, lspci -vvv, lspci -nn,
lspnp -v, cat /proc/cpuinfo etc.?

Thanks, Uwe.

[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Corey Osgood]

Uwe Hermann wrote:
> On Wed, Jun 13, 2007 at 05:23:46PM -0400, Corey Osgood wrote:
> > See attached patch. Thanks for all the great comments and suggestions!
>
> Really great work, thanks!
>
> I added the stuff to the list of supported mainboards / northbridges, as
> well as in a news item. Do you have a link to some website which shows
> the specs of the ASUS MEW-VM? I can't seem to find something suitable,
> at least not on the ASUS page.

No, sorry. What I've found out about this board amounts to this: The
MEW-VM (aka Asus "Hawk") was an OEM-only board, produced for HP and used
in a lot of their P3 and Celeron based machines. It was interchangeable
with the Trigem Cognac, which is the board HP lists on their website for
any machine that could have had either, including the Pavilion 6545C
that my board came from. I haven't been able to locate any info on HP's
site about it either, not even a user manual. The boards are available
on ebay for about $20.
> Also, can you post a detailed report on what works and what doesn't so far?
> And some more info on the board, lspci, lspci -vt, lspci -vvv, lspci -nn,
> lspnp -v, cat /proc/cpuinfo etc.?

Works:
- Serial output
- Ram size detection/setup
- Ram init
- IDE
- Booting memtest payload or loading memtest with FILO

Doesn't work yet:
- Linux kernel
- Ram buffer strength setup
- VGA
- IRQ tables

Not tested:
- Keyboard/mouse/parallel/gameport
- USB
- PCI slots

Attached are two minicom capture files, one from running without the irq
tables, the other one with them. The irq tables, for some reason, are
completely screwing up elf loader, and I have no idea why, perhaps
they're just that far wrong. Also the rest of the requested info, except
lspnp which isn't available for debian etch (??), at least not in the repos.

-Corey

processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 6
model name	: Celeron (Mendocino)
stepping	: 5
cpu MHz		: 400.925
cache size	: 128 KB
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 sep mtrr pge mca cmov pat pse36 mmx fxsr
bogomips	: 802.65

00:00.0 Host bridge: Intel Corporation 82810 GMCH [Graphics Memory Controller Hub] (rev 02)
00:01.0 VGA compatible controller: Intel Corporation 82810 CGC [Chipset Graphics Controller] (rev 02)
00:1e.0 PCI bridge: Intel Corporation 82801AA PCI Bridge (rev 01)
00:1f.0 ISA bridge: Intel Corporation 82801AA ISA Bridge (LPC) (rev 01)
00:1f.1 IDE interface: Intel Corporation 82801AA IDE (rev 01)
00:1f.2 USB Controller: Intel Corporation 82801AA USB (rev 01)
00:1f.3 SMBus: Intel Corporation 82801AA SMBus (rev 01)

00:00.0 Host bridge [0600]: Intel Corporation 82810 GMCH [Graphics Memory Controller Hub] [8086:7120] (rev 02)
00:01.0 VGA compatible controller [0300]: Intel Corporation 82810 CGC [Chipset Graphics Controller] [8086:7121] (rev 02)
00:1e.0 PCI bridge [0604]: Intel Corporation 82801AA PCI Bridge [8086:2418] (rev 01)
00:1f.0 ISA bridge [0601]: Intel Corporation 82801AA ISA Bridge (LPC) [8086:2410] (rev 01)
00:1f.1 IDE interface [0101]: Intel Corporation 82801AA IDE [8086:2411] (rev 01)
00:1f.2 USB Controller [0c03]: Intel Corporation 82801AA USB [8086:2412] (rev 01)
00:1f.3 SMBus [0c05]: Intel Corporation 82801AA SMBus [8086:2413] (rev 01)

-[0000:00]-+-00.0  Intel Corporation 82810 GMCH [Graphics Memory Controller Hub]
           +-01.0  Intel Corporation 82810 CGC [Chipset Graphics Controller]
           +-1e.0-[0000:01]--
           +-1f.0  Intel Corporation 82801AA ISA Bridge (LPC)
           +-1f.1  Intel Corporation 82801AA IDE
           +-1f.2  Intel Corporation 82801AA USB
           -1f.3  Intel Corporation 82801AA SMBus

00:00.0 Host bridge: Intel Corporation 82810 GMCH [Graphics Memory Controller Hub] (rev 02)
    Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
    Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR-
    Latency: 0

00:01.0 VGA compatible controller: Intel Corporation 82810 CGC [Chipset Graphics Controller] (rev 02) (prog-if 00 [VGA])
    Subsystem: Intel Corporation Unknown device 7123
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
    Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
    Latency: 0
    Interrupt: pin A routed to IRQ 10
    Region 0: Memory at f8000000 (32-bit, prefetchable) [size=64M]
    Region 1: Memory at f4000000 (32-bit, non-prefetchable) [size=512K]
    Capabilities: [dc] Power Management version 1
    	Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
    	Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1e.0 PCI bridge: Intel Corporation 82801AA PCI Bridge (rev 01) (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
    Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
    Latency: 0
    Bus: primary=00, secondary=01, subordinate=01, sec-latency=64
    I/O behind bridge: 0000f000-00000fff
    Memory behind bridge: fff00000-000fffff
    Prefetchable memory behind bridge: fff00000-000fffff
    Secondary status: 66MHz- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA+ VGA- MAbort- >Reset- FastB2B-

00:1f.0 ISA bridge: Intel Corporation 82801AA ISA Bridge (LPC) (rev 01)
    Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
    Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
    Latency: 0

00:1f.1 IDE interface: Intel Corporation 82801AA IDE (rev 01) (prog-if 80 [Master])
    Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
    Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
    Latency: 0
    Region 4: I/O ports at 10a0 [size=16]

00:1f.2 USB Controller: Intel Corporation 82801AA USB (rev 01) (prog-if 00 [UHCI])
    Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
    Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
    Latency: 0
    Interrupt: pin D routed to IRQ 11
    Region 4: I/O ports at 1080 [size=32]

00:1f.3 SMBus: Intel Corporation 82801AA SMBus (rev 01)
    Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
    Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
    Interrupt: pin B routed to IRQ 9
    Region 4: I/O ports at 10b0 [size=16]

[Uwe Hermann]

On Fri, Jun 15, 2007 at 04:04:54PM -0400, Corey Osgood wrote:
> > I added the stuff to the list of supported mainboards / northbridges, as
> > well as in a news item. Do you have a link to some website which shows
> > the specs of the ASUS MEW-VM? I can't seem to find something suitable,
> > at least not on the ASUS page.
>
> No, sorry. What I've found out about this board amounts to this: The
> MEW-VM (aka Asus "Hawk") was an OEM-only board, produced for HP and used
> in a lot of their P3 and Celeron based machines. It was interchangeable
> with the Trigem Cognac, which is the board HP lists on their website for
> any machine that could have had either, including the Pavilion 6545C
> that my board came from. I haven't been able to locate any info on HP's
> site about it either, not even a user manual. The boards are available
> on ebay for about $20.

OK, thanks, now we have at least _something_ to link to in the wiki :)
> > Also, can you post a detailed report on what works and what doesn't so far?
> > And some more info on the board, lspci, lspci -vt, lspci -vvv, lspci -nn,
> > lspnp -v, cat /proc/cpuinfo etc.?
>
> Works:
> Serial output
> Ram size detection/setup
> Ram init
> IDE
> Booting memtest payload or loading memtest with FILO
>
> Doesn't work yet:
> Linux kernel
> Ram buffer strength setup
> VGA
> IRQ tables
>
> Not tested:
> Keyboard/mouse/parallel/gameport
> USB
> PCI slots
>
> Attached are two minicom capture files,

Nope, I think you forgot the attachments.
> one from running without the irq
> tables, the other one with them. The irq tables, for some reason, are

Can you try to use the 'irqpoll' Linux kernel option? That may be enough
to get a complete boot up to the 'login:' prompt. The IRQ tables still
need fixing of course, but as a first work-around 'irqpoll' is nice.
> completely screwing up elf loader, and I have no idea why, perhaps
> they're just that far wrong. Also the rest of the requested info, except
> lspnp which isn't available for debian etch (??), at least not in the repos.

It's in the pnputils package.

Uwe.

[Uwe Hermann]

On Fri, Jun 15, 2007 at 10:31:23PM +0200, Uwe Hermann wrote:
> > Attached are two minicom capture files,
>
> Nope, I think you forgot the attachments.

Oops, forget about that. The attachments are there, I just didn't notice
them as they're not shown inlined in my mailer per default (unlike the
other attachments).

Uwe.

[LinuxBIOS] [PATCH] Add Asus MEW-VM, Intel i82810, and generic i82801

[Corey Osgood]

Uwe Hermann wrote:
> On Fri, Jun 15, 2007 at 04:04:54PM -0400, Corey Osgood wrote:
> > one from running without the irq
> > tables, the other one with them. The irq tables, for some reason, are
>
> Can you try to use the 'irqpoll' Linux kernel option? That may be enough
> to get a complete boot up to the 'login:' prompt. The IRQ tables still
> need fixing of course, but as a first work-around 'irqpoll' is nice.

With the non-irq tables boot, I did. Linux found IRQ4, which was
statically set to the serial port, and promptly disabled it. I can't be
sure if booting stopped at that point, or if it just killed my serial
port for the fun of it. Booting gets further (but still fails) if I
don't use irqpoll, but I didn't have the patience to wait half an hour
for another capture file.

With the irq tables, I can't get that far, I'm not sure what's going on
with that at all. I think it might be because there are more entires in
irq_tables.c than are defined by IRQ_SLOT_COUNT, but I really don't know
a whole heck of a lot about such things.
> > completely screwing up elf loader, and I have no idea why, perhaps
> > they're just that far wrong. Also the rest of the requested info, except
> > lspnp which isn't available for debian etch (??), at least not in the repos.
>
> It's in the pnputils package.

Hmm, it can't find the pnputils package. I'll just upgrade to debian
testing, this CF needs a fresh install anyways.

-Corey