[PATCH] clean up arch/i386

[Stefan Reinauer]

On the never ending quest to take complexity out of coreboot I suggest this:

- move src/arch/i386/smp/ioapic.c to src/arch/i386/lib/ioapic.c (has
nothing to do with SMP)
- move src/arch/i386/smp/mpspec.c to src/arch/i386/boot/mpspec.c (where
acpi, pirq and coreboot table generation lives)
- modify src/arch/i386/boot/Makefile.inc, src/arch/i386/lib/Makefile.inc
and src/arch/i386/smp/Makefile.inc accordingly
- src/arch/i386/smp is now empty. drop it.
- drop src/arch/i386/init/car.S (unused)

Not attached as patch, as the description and svn status is more
comprehensible.

D src/arch/i386/smp
D src/arch/i386/smp/Makefile.inc
D src/arch/i386/smp/ioapic.c
D src/arch/i386/smp/mpspec.c
M src/arch/i386/boot/Makefile.inc
A + src/arch/i386/boot/mpspec.c
D src/arch/i386/init/car.S
M src/arch/i386/lib/Makefile.inc
A + src/arch/i386/lib/ioapic.c

Signed-off-by: Stefan Reinauer

We could also go a step further and
* join boot/ and lib/
* move boot/acpi* boot/mp* boot/pir* to arch/i386/tables/ or
* move boot/acpi* to arch/i386/acpi
* move src/arch/i386/lib/cpu.c to src/cpu/x86
* move src/arch/i386/lib/walkcbfs.S to src/arch/i386/init (where
bootblock_* is)
* move src/arch/i386/lib/printk_init.c to src/arch/i386/init
* move src/arch/i386/coreboot_ram.ld to src/arch/i386/lib (where
c_start.S is)

or generally join src/arch/i386/{boot,init,lib}

and maybe even src/{cpu,arch}.

Comments?

[Patrick Georgi]

Am 20.04.2010 11:42, schrieb Stefan Reinauer:
> On the never ending quest to take complexity out of coreboot I suggest this:
> move src/arch/i386/smp/ioapic.c to src/arch/i386/lib/ioapic.c (has
>
> nothing to do with SMP)
> move src/arch/i386/smp/mpspec.c to src/arch/i386/boot/mpspec.c (where
>
> acpi, pirq and coreboot table generation lives)
> modify src/arch/i386/boot/Makefile.inc, src/arch/i386/lib/Makefile.inc
>
> and src/arch/i386/smp/Makefile.inc accordingly
> src/arch/i386/smp is now empty. drop it.
> drop src/arch/i386/init/car.S (unused)

Nice!
> Signed-off-by: Stefan Reinauer

Acked-by: Patrick Georgi
> move boot/acpi* boot/mp* boot/pir* to arch/i386/tables/ or
> move boot/acpi* to arch/i386/acpi

I'd like the tables to be as unified as possible (esp. when they're auto
generated at some point). So the first proposal sounds more appropriate.
> move src/arch/i386/lib/walkcbfs.S to src/arch/i386/init (where
>
> bootblock_* is)

Maybe move all of that to src/arch/i386/bootblock?
> and maybe even src/{cpu,arch}.

Hmm.. I consider src/cpu to be "CPU drivers", while src/arch is
"architecture specific infrastructure". Not sure if that distinction is
really useful.

Patrick

[Peter Stuge]

Patrick Georgi wrote:
> > move src/arch/i386/smp/ioapic.c to src/arch/i386/lib/ioapic.c (has
> >
> > nothing to do with SMP)
> > move src/arch/i386/smp/mpspec.c to src/arch/i386/boot/mpspec.c (where
> >
> > acpi, pirq and coreboot table generation lives)
> > modify src/arch/i386/boot/Makefile.inc, src/arch/i386/lib/Makefile.inc
> >
> > and src/arch/i386/smp/Makefile.inc accordingly
> > src/arch/i386/smp is now empty. drop it.
> > drop src/arch/i386/init/car.S (unused)
>
> Nice!
> > Signed-off-by: Stefan Reinauer
>
> Acked-by: Patrick Georgi

Acked-by: Peter Stuge
> > move boot/acpi* boot/mp* boot/pir* to arch/i386/tables/ or
> > move boot/acpi* to arch/i386/acpi
>
> I'd like the tables to be as unified as possible (esp. when they're auto
> generated at some point). So the first proposal sounds more appropriate.
> > move src/arch/i386/lib/walkcbfs.S to src/arch/i386/init (where
> >
> > bootblock_* is)
>
> Maybe move all of that to src/arch/i386/bootblock?
> > and maybe even src/{cpu,arch}.
>
> Hmm.. I consider src/cpu to be "CPU drivers", while src/arch is
> "architecture specific infrastructure". Not sure if that distinction is
> really useful.

I agree with Patrick in all the above. :)

//Peter