Hi,
I'm currently working on the backlog we have with patches and wanted to point out a nice tool we have for that.
On http://patchwork.coreboot.org/project/coreboot/list/ you can find a patchwork installation which tracks our mailing list, keeping watch over submitted patches and the discussions related to them.
Please feel encourage to look there for patches that seem to be forgotten, and review them, bring them alive again, and make sure, they can get in (or get improved on, if they need more work).
Patches that are sufficiently processed (accepted/committed, rejected, superseded, etc) disappear from view, so as long as the default view on that page lists patches, there's still a patch that waits for someone to take care of it.
It's also a good place to keep track of the patches you submitted over time, to see if they're in already. The patch list should be quite recent about which patches are in and which aren't.
If you require additional privileges on patchwork, please tell me, and I'll set things up appropriately.
Patrick
On 23.02.2010 11:43, Patrick Georgi wrote:
On http://patchwork.coreboot.org/project/coreboot/list/ you can find a patchwork installation which tracks our mailing list, keeping watch over submitted patches and the discussions related to them.
Please feel encourage to look there for patches that seem to be forgotten, and review them, bring them alive again, and make sure, they can get in (or get improved on, if they need more work).
Thanks for starting this effort, Patrick. I am going through the flashrom patches from time to time, and there the overview is pretty current (and yes, we have a massive backlog of board enable patches because testers usually disappear after the code works for them).
Regards, Carl-Daniel
On Tue, Feb 23, 2010 at 3:43 AM, Patrick Georgi patrick@georgi-clan.dewrote:
Hi,
I'm currently working on the backlog we have with patches and wanted to point out a nice tool we have for that.
On http://patchwork.coreboot.org/project/coreboot/list/ you can find a patchwork installation which tracks our mailing list, keeping watch over submitted patches and the discussions related to them.
It seems like it would be a lot more useful if it tracked commits. Since it finds patches automatically, can it also find commits automatically?
Thanks, Myles
Am 23.02.2010 17:32, schrieb Myles Watson:
It seems like it would be a lot more useful if it tracked commits. Since it finds patches automatically, can it also find commits automatically?
Limited, yes. There's a script that matches commit diffs with diffs in the database. Unfortunately, they don't always match up, as the order of files within the patch isn't normalized.
But nearly all of the committed patches should be marked "accepted" by that script and manual work already.
Patrick
On Tue, Feb 23, 2010 at 9:34 AM, Patrick Georgi patrick@georgi-clan.dewrote:
Am 23.02.2010 17:32, schrieb Myles Watson:
It seems like it would be a lot more useful if it tracked commits. Since it finds patches automatically, can it also find commits automatically?
Limited, yes. There's a script that matches commit diffs with diffs in the database. Unfortunately, they don't always match up, as the order of files within the patch isn't normalized.
Maybe it should match the "Rev 5217" messages in replies to the Acked-by messages.
But nearly all of the committed patches should be marked "accepted" by that script and manual work already.
Is this based on Acked-by? I asked because there's a patch submitted by Stefan and Acked-by Ron that shows up.
Thanks, Myles
Am 23.02.2010 17:37, schrieb Myles Watson:
But nearly all of the committed patches should be marked "accepted" by that script and manual work already.Is this based on Acked-by? I asked because there's a patch submitted by Stefan and Acked-by Ron that shows up.
No, by fetching diffs from the repository, normalizing them in some way and creating a hash on that. Each patch in the database has such a hash, too.
-
Carl-Daniel Hailfinger -
Myles Watson -
Patrick Georgi