Re: [coreboot] [v2] r4245 - in trunk/coreboot-v2: src/mainboard/rca/rm4100 src/mainboard/thomson/ip1000 targets/rca/rm4100 targets/thomson/ip1000
On 01.05.2009 6:44 Uhr, svn@coreboot.org wrote:
Modified: trunk/coreboot-v2/src/mainboard/thomson/ip1000/Options.lb
--- trunk/coreboot-v2/src/mainboard/thomson/ip1000/Options.lb 2009-05-01 04:37:13 UTC (rev 4244) +++ trunk/coreboot-v2/src/mainboard/thomson/ip1000/Options.lb 2009-05-01 04:44:36 UTC (rev 4245) @@ -24,6 +24,7 @@ uses CONFIG_CONSOLE_VGA uses CONFIG_COMPRESSED_PAYLOAD_LZMA uses CONFIG_IOAPIC +uses CONFIG_PCI_OPTION_ROM_RUN_VM86 uses CONFIG_PCI_ROM_RUN uses CONFIG_ROM_PAYLOAD uses CONFIG_ROM_PAYLOAD_START @@ -78,6 +79,7 @@ default HAVE_OPTION_TABLE = 0 default CONFIG_CONSOLE_VGA = 0 default CONFIG_PCI_ROM_RUN = 0 +default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 0 default CONFIG_VIDEO_MB = 0 default STACK_SIZE = 0x2000 default HEAP_SIZE = 0x4000
Modified: trunk/coreboot-v2/targets/rca/rm4100/Config.lb
--- trunk/coreboot-v2/targets/rca/rm4100/Config.lb 2009-05-01 04:37:13 UTC (rev 4244) +++ trunk/coreboot-v2/targets/rca/rm4100/Config.lb 2009-05-01 04:44:36 UTC (rev 4245) @@ -37,6 +37,7 @@ ## option CONFIG_CONSOLE_VGA = 1 option CONFIG_PCI_ROM_RUN = 1 +option CONFIG_PCI_OPTION_ROM_RUN_VM86 = 1
## ## Choose the amount of memory pre-allocated for VGA
Dumb question: Why are you setting CONFIG_PCI_OPTION_ROM_RUN_VM86 to 0 in the mainboard Options.lb file and to 1 in the target Config.lb?
This implies that VM86 should not_ be used by default. Is this the case?
It also means that you're abuild-testing the image with x86emu, but using an image with VM86.
Stefan
On Fri, 01 May 2009 11:36:32 +0200, Stefan Reinauer stepan@coresystems.de wrote:
On 01.05.2009 6:44 Uhr, svn@coreboot.org wrote:
Modified: trunk/coreboot-v2/src/mainboard/thomson/ip1000/Options.lb
--- trunk/coreboot-v2/src/mainboard/thomson/ip1000/Options.lb 2009-05-01
04:37:13 UTC (rev 4244)
+++ trunk/coreboot-v2/src/mainboard/thomson/ip1000/Options.lb 2009-05-01
04:44:36 UTC (rev 4245)
@@ -24,6 +24,7 @@ uses CONFIG_CONSOLE_VGA uses CONFIG_COMPRESSED_PAYLOAD_LZMA uses CONFIG_IOAPIC +uses CONFIG_PCI_OPTION_ROM_RUN_VM86 uses CONFIG_PCI_ROM_RUN uses CONFIG_ROM_PAYLOAD uses CONFIG_ROM_PAYLOAD_START @@ -78,6 +79,7 @@ default HAVE_OPTION_TABLE = 0 default CONFIG_CONSOLE_VGA = 0 default CONFIG_PCI_ROM_RUN = 0 +default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 0 default CONFIG_VIDEO_MB = 0 default STACK_SIZE = 0x2000 default HEAP_SIZE = 0x4000
Modified: trunk/coreboot-v2/targets/rca/rm4100/Config.lb
--- trunk/coreboot-v2/targets/rca/rm4100/Config.lb 2009-05-01 04:37:13
UTC (rev 4244)
+++ trunk/coreboot-v2/targets/rca/rm4100/Config.lb 2009-05-01 04:44:36
UTC (rev 4245)
@@ -37,6 +37,7 @@ ## option CONFIG_CONSOLE_VGA = 1 option CONFIG_PCI_ROM_RUN = 1 +option CONFIG_PCI_OPTION_ROM_RUN_VM86 = 1
## ## Choose the amount of memory pre-allocated for VGA
Dumb question: Why are you setting CONFIG_PCI_OPTION_ROM_RUN_VM86 to 0 in the mainboard Options.lb file and to 1 in the target Config.lb?
This implies that VM86 should not_ be used by default. Is this the case?
It also means that you're abuild-testing the image with x86emu, but using an image with VM86.
Because, I have some people that use use these boxes in "headless mode" for LAMP servers, Asterisk servers, etc. So I want to keep all the vga stuff togethor and an "option" making their boot time as fast as possible. And I think it was Ron that once said that most options should always be set in targets Config.lb. Should I update the abuild Config.lb to reflect my normal Config.lb?
On Fri, May 1, 2009 at 4:50 AM, Joseph Smith joe@settoplinux.org wrote:
Because, I have some people that use use these boxes in "headless mode" for LAMP servers, Asterisk servers, etc. So I want to keep all the vga stuff togethor and an "option" making their boot time as fast as possible. And I think it was Ron that once said that most options should always be set in targets Config.lb. Should I update the abuild Config.lb to reflect my normal Config.lb?
What's the normal usage?
If the most common usage is the headless stuff then it should default 0.
This is always a judgement call. One thing to note: if if has been 0, and you change it 1, you are going to have to tell any users of headless that they need to make new target with this set to 0.
How will the unconditional inclusion of the vga.o (from the other thread) affect headless users? It still seems to me that it would be easy to say if CONFIG_CONSOLE_VGA object vga.o end
to cover that case.
ron
On Fri, 1 May 2009 09:04:44 -0700, ron minnich rminnich@gmail.com wrote:
On Fri, May 1, 2009 at 4:50 AM, Joseph Smith joe@settoplinux.org wrote:
Because, I have some people that use use these boxes in "headless mode"
for
LAMP servers, Asterisk servers, etc. So I want to keep all the vga stuff togethor and an "option" making their boot time as fast as possible. And
I
think it was Ron that once said that most options should always be set
in
targets Config.lb. Should I update the abuild Config.lb to reflect my normal Config.lb?
What's the normal usage?
A set-top-box of course! The problem with that is it doesn't have a VGA connector, only tv-out. So unless you are soldering crafty and can solder on a vga connector, you are limited to serial console or ssh. But, very soon the tv-out will be working and set-top-box all the way :-)
If the most common usage is the headless stuff then it should default 0.
This is always a judgement call. One thing to note: if if has been 0, and you change it 1, you are going to have to tell any users of headless that they need to make new target with this set to 0.
Right.
How will the unconditional inclusion of the vga.o (from the other thread) affect headless users? It still seems to me that it would be easy to say if CONFIG_CONSOLE_VGA object vga.o end
Hmm, interesting. I was also thinking about making it a little more user friendly by wrapping all the vga options into one. Something like in mainboard Options.lb:
#ifdef VGA_ENABLE /* or some other global define */ default CONFIG_CONSOLE_VGA = 1 default CONFIG_PCI_ROM_RUN = 1 default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 1 default CONFIG_VIDEO_MB = 8 #else default CONFIG_CONSOLE_VGA = 0 default CONFIG_PCI_ROM_RUN = 0 default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 0 default CONFIG_VIDEO_MB = 0 #endif
An then all the user would have to do in targets Config.lb is:
## Enable VGA off=0(default) On=1 option VGA_ENABLE = 1
Would that work?
How will the unconditional inclusion of the vga.o (from the other thread) affect headless users? It still seems to me that it would be easy to say if CONFIG_CONSOLE_VGA object vga.o end
Hmm, interesting. I was also thinking about making it a little more user friendly by wrapping all the vga options into one. Something like in mainboard Options.lb:
You have to be careful with #ifdef because our options are always defined. You probably meant #if VGA == 1.
#ifdef VGA_ENABLE /* or some other global define */ default CONFIG_CONSOLE_VGA = 1 default CONFIG_PCI_ROM_RUN = 1 default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 1 default CONFIG_VIDEO_MB = 8 #else default CONFIG_CONSOLE_VGA = 0 default CONFIG_PCI_ROM_RUN = 0 default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 0 default CONFIG_VIDEO_MB = 0 #endif
I would think it would be easier to do something like:
default CONFIG_PCI_ROM_RUN = CONFIG_CONSOLE_VGA default CONFIG_PCI_OPTION_ROM_RUN_VM86 = CONFIG_CONSOLE_VGA default CONFIG_VIDEO_MB = CONFIG_CONSOLE_VGA * 8 /* A little hackish. */
An then all the user would have to do in targets Config.lb is:
## Enable VGA off=0(default) On=1 option VGA_ENABLE = 1
option CONFIG_CONSOLE_VGA = 1
Thanks, Myles
On Fri, May 1, 2009 at 1:14 PM, Myles Watson mylesgw@gmail.com wrote:
option CONFIG_CONSOLE_VGA = 1
Yes, I think Myles has the right idea. That CONFIG_CONSOLE_VGA is there for a reason.
ron
Myles Watson wrote:
How will the unconditional inclusion of the vga.o (from the other thread) affect headless users? It still seems to me that it would be easy to say if CONFIG_CONSOLE_VGA object vga.o end
Hmm, interesting. I was also thinking about making it a little more user friendly by wrapping all the vga options into one. Something like in mainboard Options.lb:
You have to be careful with #ifdef because our options are always defined. You probably meant #if VGA == 1.
#ifdef VGA_ENABLE /* or some other global define */ default CONFIG_CONSOLE_VGA = 1 default CONFIG_PCI_ROM_RUN = 1 default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 1 default CONFIG_VIDEO_MB = 8 #else default CONFIG_CONSOLE_VGA = 0 default CONFIG_PCI_ROM_RUN = 0 default CONFIG_PCI_OPTION_ROM_RUN_VM86 = 0 default CONFIG_VIDEO_MB = 0 #endif
I would think it would be easier to do something like:
default CONFIG_PCI_ROM_RUN = CONFIG_CONSOLE_VGA default CONFIG_PCI_OPTION_ROM_RUN_VM86 = CONFIG_CONSOLE_VGA default CONFIG_VIDEO_MB = CONFIG_CONSOLE_VGA * 8 /* A little hackish. */
Normally, with coreboot and VGA initialization, you don't want CONFIG_CONSOLE_VGA, as that's just the last few boot messages of table creation. It's not really good for debugging anymore. In v3 we were smart and deleted CONFIG_CONSOLE_VGA completely, leaving any VGA _output_ to the payloads.
I think we should do the same thing in v2.
-
Joseph Smith -
Myles Watson -
ron minnich -
Stefan Reinauer