[PATCH] [buildrom] add PC Engines Alix.2c3

[Ward Vandewege]

The subject says it all.

Thanks,
Ward.

[Uwe Hermann]

On Sat, Apr 19, 2008 at 10:55:53AM -0400, Ward Vandewege wrote:
> Add PC Engines Alix.2c3 platform.
>
> Signed-off-by: Ward Vandewege

Acked-by: Uwe Hermann

but see below.
> Index: config/platforms/alix2c3.conf
>
> --- config/platforms/alix2c3.conf	(revision 0)
> +++ config/platforms/alix2c3.conf	(revision 0)
> @@ -0,0 +1,40 @@
> +# Support for the PC Engines ALIX2C3 platform

ALIX2.C3 as per website please.
> +TARGET_ARCH=i586

Intentional or did you mean i686? Does the Geode LX have problems when
using i686?
> +CFLAGS_platform =
>
> +# Targets
>
> +KERNEL_MK=$(PACKAGE_DIR)/kernel/alix2c3.mk
> +CBV2_MK=$(PACKAGE_DIR)/coreboot-v2/geodelx.mk

As the board is only supported in v3, this would break. Not sure how to
handle this properly. How hard would it be to also add the board to
coreboot v2?
> +# kernel configuration (for LAB)
>
> +KERNEL_VERSION=2.6.20.2
> +KERNEL_CONFIG=$(PACKAGE_DIR)/kernel/conf/defconfig-alix2c3
> +UCLIBC_ARCH=i386
>
> +# Etherboot configuration
> +ETHERBOOT_ARCH=i386
>
> +# coreboot configuration
>
> +COREBOOT_VENDOR=pcengines
> +COREBOOT_BOARD=alix2c3
> +CBV2_CONFIG=Config.lb
> +CBV2_PAYLOAD_FILE_EXT=elf
> +CBV2_TDIR=alix2c3
> +CBV2_TAG=3079

Ditto, v2 issues?
> +CBV3_TAG=665
>
> +# FILO configuration
>
> +FILO_CONFIG=alix2c3-Config
> Index: config/platforms/platforms.conf
>
> --- config/platforms/platforms.conf	(revision 149)
> +++ config/platforms/platforms.conf	(working copy)
> @@ -9,6 +9,7 @@
>  PLATFORM-$(CONFIG_PLATFORM_NORWICH) = norwich.conf
>  PLATFORM-$(CONFIG_PLATFORM_MSM800SEV) = msm800sev.conf
>  PLATFORM-$(CONFIG_PLATFORM_ALIX1C) = alix1c.conf
> +PLATFORM-$(CONFIG_PLATFORM_ALIX2C3) = alix2c3.conf
>  PLATFORM-$(CONFIG_PLATFORM_DB800) = db800.conf
>  PLATFORM-$(CONFIG_PLATFORM_DBE61) = dbe61.conf
>  PLATFORM-$(CONFIG_PLATFORM_GA_M57SLI_S4) = m57sli.conf
> Index: config/platforms/Config.in
> ===================================================================
> --- config/platforms/Config.in	(revision 149)
> +++ config/platforms/Config.in	(working copy)
> @@ -59,6 +59,12 @@
>         select PLATFORM
>         select PLATFORM_GEODE
>
> +config PLATFORM_ALIX2C3
>   bool "PC Engines ALIX.2C3"

ALIX2.C3
>   depends VENDOR_PC_ENGINES
>   select PLATFORM
>   select PLATFORM_GEODE
>
> config PLATFORM_MSM800SEV
>         bool "Advanced Digital Logic MSM800SEV"
>         depends on VENDOR_ADVANCED_DIGITAL_LOGIC
> Index: packages/kernel/conf/defconfig-alix2c3
> ===================================================================
> --- packages/kernel/conf/defconfig-alix2c3	(revision 0)
> +++ packages/kernel/conf/defconfig-alix2c3	(revision 0)
> @@ -0,0 +1,1425 @@
> Index: packages/kernel/alix2c3.mk
>
> --- packages/kernel/alix2c3.mk	(revision 0)
> +++ packages/kernel/alix2c3.mk	(revision 0)
> @@ -0,0 +1,19 @@
> +# Build file for the PC Engines ALIX.2C3 LAB kernel

ALIX2.C3
> +KERNEL_URL=http://kernel.org/pub/linux/kernel/v2.6/
> +KERNEL_SOURCE=linux-$(KERNEL_VERSION).tar.bz2
> +KERNEL_CONFIG=$(PACKAGE_DIR)/kernel/conf/defconfig-alix2c3
>
> +#TINY_DIR=$(PACKAGE_DIR)/kernel/patches/tiny
> +#KERNEL_PATCHES += $(shell ls $(TINY_DIR)/*.patch)
>
> +$(SOURCE_DIR)/$(KERNEL_SOURCE):
> @ mkdir -p $(SOURCE_DIR)
> @ wget -P $(SOURCE_DIR) $(KERNEL_URL)/$(KERNEL_SOURCE)
>
> +include $(PACKAGE_DIR)/kernel/kernel.inc
>
> +kernel: generic-kernel
> +kernel-clean: generic-kernel-clean
> +kernel-distclean: generic-kernel-distclean
> Index: packages/filo/conf/alix2c3-Config
> ===================================================================
> --- packages/filo/conf/alix2c3-Config	(revision 0)
> +++ packages/filo/conf/alix2c3-Config	(revision 0)
> @@ -0,0 +1,50 @@
> +# Use grub instead of autoboot?
> +USE_GRUB = 1
> +# Grub menu.lst path

I'd personally remove the comments from this file, the docs belong in
FILO's README or in the wiki IMO.

Uwe.

[Uwe Hermann]

On Sun, Apr 20, 2008 at 12:00:25AM +0200, Uwe Hermann wrote:
> > Index: config/platforms/alix2c3.conf
> >
> > --- config/platforms/alix2c3.conf	(revision 0)
> > +++ config/platforms/alix2c3.conf	(revision 0)
> > @@ -0,0 +1,40 @@
> > +# Support for the PC Engines ALIX2C3 platform
>
> ALIX2.C3 as per website please.

Eh, crap, should be ALIX.2C3 of course.

Uwe.

[Ward Vandewege]

On Sun, Apr 20, 2008 at 12:00:25AM +0200, Uwe Hermann wrote:
> On Sat, Apr 19, 2008 at 10:55:53AM -0400, Ward Vandewege wrote:
> > Add PC Engines Alix.2c3 platform.
> >
> > Signed-off-by: Ward Vandewege
>
> Acked-by: Uwe Hermann

r152, with your concerns addressed:

* i586 is correct, as per discussion on IRC.
* removed all coreboot v2 stuff - this board is v3 only (our first!) though a
  v2 port should be pretty trivial.
* the correct board name is ALIX.2c3
* removed comments from FILO config file.

Tested on real hardware.

Thanks,
Ward.