Re: [coreboot] Patch for enableing 440BX NB to use large memory modules

[Anders Jenbo]

> > Single sided 512MB (what I used to test), becomes a 128MB.
> > A asymmetric 384MB double sided modules, with 256MB on one side
>
> and
> > 128MB on the other. Becomes two sides with 128MB (a 256MB module).
> > This is also enabled in at least some BIOSs (GA-BXC).
> >
> > The patch also cleans up some whitespace.
> >
> > Signed-off-by: Anders Jenbo
>
> I like this...  no hardware to test though...
> Acked-by: Stefan Reinauer

Thanks

I dug threw the datacheet:
http://download.intel.com/design/chipsets/datashts/29063301.pdf

On page 3-31 (PDF page 57) the first box is the only real hint at this.
on page 4-4 under 4.1.1.2 (PDF page 90 there is a reference to 4GB of memory), on the next page there is a reference to 4GB being the maximum physically supported amount of memory.

So my conclusion is that you can install a maximum of 4GB but only 128MB per DIMM side will be addressable/possible to initialized.

I have another 440BX based board with 4 DIMMs (GA-6BXC has 3 DIMMs), once I have ported CoreBoot for it, I will gladly preform more real world tests. I also found some more SDRAM to test with (one of them is 512MB I belive), It's also posible that i can borrow more Ram for testing from work.

Stefan, since you acked the patch, should I still correct the typos that Paul pointed out and split it in to a patch, one with the added memory support and one with the cleaned white space?

Glad to be a contributing part to CoreBoot :)

-Anders
---- Msg sent via @Mail - http://atmail.com/

Patch for enableing 440BX NB to use large memory modules

[Stefan Reinauer]

On 4/26/10 4:24 PM, Anders Jenbo wrote:
> Stefan, since you acked the patch, should I still correct the typos that Paul pointed out and split it in to a patch, one with the added memory support and one with the cleaned white space?

That would be awesome!

Patch for enableing 440BX NB to use large memory modules

[Anders Jenbo]

man, 26 04 2010 kl. 16:53 +0200, skrev Stefan Reinauer:
> On 4/26/10 4:24 PM, Anders Jenbo wrote:
> > Stefan, since you acked the patch, should I still correct the typos that Paul pointed out and split it in to a patch, one with the added memory support and one with the cleaned white space?
>
> That would be awesome!

Ok i fixed the typos and removed the white space clean up.

[PATCH v3] Patch for enableing 440BX NB to use large memory modules

[Paul Menzel]

Am Dienstag, den 27.04.2010, 00:42 +0200 schrieb Anders Jenbo:
> man, 26 04 2010 kl. 16:53 +0200, skrev Stefan Reinauer:
> > On 4/26/10 4:24 PM, Anders Jenbo wrote:
> > > Stefan, since you acked the patch, should I still correct the typos that Paul pointed out and split it in to a patch, one with the added memory support and one with the cleaned white space?
> >
> > That would be awesome!
>
> Ok i fixed the typos and removed the white space clean up.

I added the full stops and attached the updated version.

Just in case it is needed:

Signed-off-by: Paul Menzel

Anders, you forgot yours sending the updated patch. (Although I also do
not know if it is needed.)

Signed-off-by: Anders Jenbo

Thanks,

Paul

[PATCH v3] Patch for enableing 440BX NB to use large memory modules

[Anders Jenbo]

Paul's one is fine so use that.

Mvh Anders

Den 27/04/2010 kl. 09.16 skrev Paul Menzel <[e-mail]
> :
> Am Dienstag, den 27.04.2010, 00:42 +0200 schrieb Anders Jenbo:
> > man, 26 04 2010 kl. 16:53 +0200, skrev Stefan Reinauer:
> > > On 4/26/10 4:24 PM, Anders Jenbo wrote:
> > > > Stefan, since you acked the patch, should I still correct the  
> > > > typos that Paul pointed out and split it in to a patch, one with  
> > > > the added memory support and one with the cleaned white space?
> > >
> > > That would be awesome!
> >
> > Ok i fixed the typos and removed the white space clean up.
>
> I added the full stops and attached the updated version.
>
> Just in case it is needed:
>
> Signed-off-by: Paul Menzel
>
> Anders, you forgot yours sending the updated patch. (Although I also  
> do
> not know if it is needed.)
>
> Signed-off-by: Anders Jenbo
>
> Thanks,
>
> Paul
> <440BX-use-large-memory-modules.patch>
>
> coreboot mailing list: [e-mail]
> http://www.coreboot.org/mailman/listinfo/coreboot

[PATCH v3] Patch for enableing 440BX NB to use large memory modules

[Peter Stuge]

Anders Jenbo wrote:
> Paul's one is fine so use that.

That's r5508. Thanks!

//Peter

Patch for enableing 440BX NB to use large memory modules

[Peter Stuge]

Anders Jenbo wrote:
> should I still correct the typos that Paul pointed out and split it
> in to a patch, one with the added memory support and one with the
> cleaned white space?

Yes please. It's not only important to separate whitespace to make
review as easy as possible, but it is also very important to make
future code comparison between old and new revisions as easy as
possible. These are both really important, since they create extra
work, and it's easy to avoid them.

Thanks.

//Peter