[PATCH] CBFS for via vt8454c

[Patrick Georgi]

Hi,

attached patch enables CBFS for the VIA vt8454c board (via cx700 chipset). 
It's compile and boot tested.

Signed-off-by: Patrick Georgi

[Myles Watson]

> Hi,
>
> attached patch enables CBFS for the VIA vt8454c board (via cx700 chipset).
> It's compile and boot tested.

I don't understand why this board needs a Config-abuild.lb.  It seems like
if we want one it should build normal and fallback images like Config.lb
does.

I think that the pci_rom line:

+#pci_rom $(TOP)/via-cx700.rom vendor_id=0x1106 device_id=0x3157

belongs in Config.lb instead.
> Signed-off-by: Patrick Georgi

Acked-by: Myles Watson

Thanks,
Myles

[Patrick Georgi]

Am Montag 27 April 2009 20:12:45 schrieb Myles Watson:
> > Hi,
> >
> > attached patch enables CBFS for the VIA vt8454c board (via cx700
> > chipset). It's compile and boot tested.
>
> I don't understand why this board needs a Config-abuild.lb.  It seems like
> if we want one it should build normal and fallback images like Config.lb
> does.

I can't tell you why it is already there. But, as I use abuild for my local 
work, I rely on those files and edit those when necessary.

Patrick

[Peter Stuge]

Patrick Georgi wrote:
> +#pci_rom $(TOP)/via-cx700.rom vendor_id=0x1106 device_id=0x3157

Is this the VGA option ROM? Maybe via-cx700-vga.rom then?

I really like having the PCI ID in the filename though. I favor
removing vendor_id and device_id from pci_rom. The filename could be
checked to really include the IDs.

//Peter

[Myles Watson]

On Mon, Apr 27, 2009 at 4:15 PM, Peter Stuge  wrote:
> Patrick Georgi wrote:
> > +#pci_rom $(TOP)/via-cx700.rom vendor_id=0x1106 device_id=0x3157
>
> Is this the VGA option ROM? Maybe via-cx700-vga.rom then?
>
> I really like having the PCI ID in the filename though. I favor
> removing vendor_id and device_id from pci_rom. The filename could be
> checked to really include the IDs.

How would you do that at build time?  There are boards that need
multiple ROMS (scsi, nic, vga ...)  Another problem is that sometimes
you want to have pxe be the ROM.  The point is that the filename is
whatever the user wants to call it in his own filesystem, but the pci
IDs have to be right or it won't work.

Myles