Not sure about this one. Help?
//Peter
Hi,
that definition seems to be leftover from the porting efforts... it was for another romfs though... since its not used in yabel anywhere currently... i would say we can remove the line altogether...
diff --git a/util/x86emu/yabel/compat/of.h b/util/x86emu/yabel/compat/of.h index aced2d5..9071399 100644 --- a/util/x86emu/yabel/compat/of.h +++ b/util/x86emu/yabel/compat/of.h @@ -48,7 +48,6 @@ void of_release(void *, unsigned int ); int of_yield(void); void * of_set_callback(void *);
-unsigned int romfs_lookup(const char *, void **); int vpd_read(unsigned int , unsigned int , char *); int vpd_write(unsigned int , unsigned int , char *); int write_mm_log(char *, unsigned int , unsigned short );
Signed-off-by: Pattrick Hueper phueper@hueper.net
On Tue, Apr 14, 2009 at 2:16 AM, Peter Stuge peter@stuge.se wrote:
Not sure about this one. Help?
//Peter
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Pattrick Hueper wrote:
that definition seems to be leftover from the porting efforts... it was for another romfs though...
Ok! That was my guess from dates and so on.
since its not used in yabel anywhere currently... i would say we can remove the line altogether...
Great. Thanks for looking at this!
--- a/util/x86emu/yabel/compat/of.h +++ b/util/x86emu/yabel/compat/of.h @@ -48,7 +48,6 @@ void of_release(void *, unsigned int ); int of_yield(void); void * of_set_callback(void *);
-unsigned int romfs_lookup(const char *, void **); int vpd_read(unsigned int , unsigned int , char *); int vpd_write(unsigned int , unsigned int , char *); int write_mm_log(char *, unsigned int , unsigned short );
Signed-off-by: Pattrick Hueper phueper@hueper.net
Acked-by: Peter Stuge peter@stuge.se
On Tue, Apr 14, 2009 at 10:24 AM, Peter Stuge peter@stuge.se wrote:
Pattrick Hueper wrote:
that definition seems to be leftover from the porting efforts... it was for another romfs though...
Ok! That was my guess from dates and so on.
since its not used in yabel anywhere currently... i would say we can remove the line altogether...
Great. Thanks for looking at this!
--- a/util/x86emu/yabel/compat/of.h +++ b/util/x86emu/yabel/compat/of.h @@ -48,7 +48,6 @@ void of_release(void *, unsigned int ); int of_yield(void); void * of_set_callback(void *);
-unsigned int romfs_lookup(const char *, void **); int vpd_read(unsigned int , unsigned int , char *); int vpd_write(unsigned int , unsigned int , char *); int write_mm_log(char *, unsigned int , unsigned short );
Signed-off-by: Pattrick Hueper phueper@hueper.net
Acked-by: Peter Stuge peter@stuge.se
Thanks, r1163
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot