Re: [coreboot] Patch merged into coreboot/master: c35c461 Invalidate cache before first jump
Hi, It is unstable. In most cases, it hangs at this wbinvd. Once it pass that instruction, it will hang at when AP cores are launched.
Joe
-----Original Message----- From: Marc Jones [mailto:marcj303@gmail.com] Sent: Friday, April 06, 2012 11:27 PM To: Bao, Zheng Cc: coreboot@coreboot.org; Marc Jones Subject: Re: [coreboot] Patch merged into coreboot/master: c35c461 Invalidate cache before first jump
Can you be more descriptive to how it fails? Does it hang on that instruction?
Marc
On Fri, Apr 6, 2012 at 5:38 AM, Bao, Zheng Zheng.Bao@amd.com wrote:
Actually, it hurts my board. AMD trinity fam15 + Hudson.
Zheng
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot- bounces@coreboot.org] On Behalf Of gerrit@coreboot.org Sent: Friday, April 06, 2012 5:03 AM To: coreboot@coreboot.org Subject: [coreboot] Patch merged into coreboot/master: c35c461 Invalidate cache before first jump
the following patch was just integrated into master: commit c35c461bb2146ab949062f22e265406deef178d2 Author: Stefan Reinauer reinauer@chromium.org Date: ? Tue Apr 3 16:09:46 2012 -0700
? ? Invalidate cache before first jump
? ? Some CPUs (Sandybridge) seem to require this, and it does not
hurt
? ? on other CPUs.
? ? Change-Id: I4fdb281b2b684ab5fea999aae28ca08dce24da4d ? ? Signed-off-by: Stefan Reinauer reinauer@google.com
Build-Tested: build bot (Jenkins) at Thu Apr ?5 23:02:43 2012,
giving
+1 See http://review.coreboot.org/869 for details.
-gerrit
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On 09/04/12 04:24, Bao, Zheng wrote:
Hi, It is unstable. In most cases, it hangs at this wbinvd. Once it pass that instruction, it will hang at when AP cores are launched.
Try invd instead of wbinvd. There should be no need to preserve anything from the cache so the write back is not needed. The write back may also need functional memory which will not be there at least from power on. Also note that these instructions are 486+ only.
Andrew
I tried. It behaves as bad as wbinvd does.
Joe
-----Original Message----- From: Andrew Goodbody [mailto:ajg4tadpole@gmail.com] Sent: Tuesday, April 10, 2012 7:04 PM To: Bao, Zheng Cc: 'Marc Jones'; Marc Jones; 'coreboot@coreboot.org' Subject: Re: [coreboot] Patch merged into coreboot/master: c35c461 Invalidate cache before first jump
On 09/04/12 04:24, Bao, Zheng wrote:
Hi, It is unstable. In most cases, it hangs at this wbinvd. Once it pass
that instruction, it will hang at when AP cores are launched.
Try invd instead of wbinvd. There should be no need to preserve anything from the cache so the write back is not needed. The write back may also need functional memory which will not be there at least from power on. Also note that these instructions are 486+ only.
Andrew
On Tue, Apr 10, 2012 at 5:29 AM, Bao, Zheng Zheng.Bao@amd.com wrote:
I tried. It behaves as bad as wbinvd does.
Joe
-----Original Message----- From: Andrew Goodbody [mailto:ajg4tadpole@gmail.com] Sent: Tuesday, April 10, 2012 7:04 PM To: Bao, Zheng Cc: 'Marc Jones'; Marc Jones; 'coreboot@coreboot.org' Subject: Re: [coreboot] Patch merged into coreboot/master: c35c461 Invalidate cache before first jump
On 09/04/12 04:24, Bao, Zheng wrote:
Hi, It is unstable. In most cases, it hangs at this wbinvd. Once it pass
that instruction, it will hang at when AP cores are launched.
Try invd instead of wbinvd. There should be no need to preserve anything from the cache so the write back is not needed. The write back may also need functional memory which will not be there at least from power on. Also note that these instructions are 486+ only.
Andrew
An wbind/invd by the APs may to cause problems with CAR. I think that the coherency rules will cause a wbind on all cores, but I am not positive.
Stefan, can you explain the requirement or consider how else to only do this on a processor that requires it?
Marc
-
Andrew Goodbody -
Bao, Zheng -
Marc Jones