Re: [coreboot] Kaby Lake FSP

[Desimone, Nathaniel L]

Hi Patrick,

The distribution permissions granted in section 2.1 (b) and (c) are only granted for internal distribution. So, they can only be used to distribute the FSP binary to other people that are within the same legal entity (such as a corporation, partnership, agency, etc.) that you are in. The only external distribution rights are those granted by section 2.1 (e) and (f), both of which require that FSP has already been embedded into the final coreboot ROM binary. Since the coreboot blobs repo is publicly accessible it would count as external distribution, which is disallowed by the FSP license.

However, there is nothing in the license that prevents you from providing links to github.com/IntelFsp. It might not be exactly what you were hoping for but would adding a git submodule in coreboot blobs that points to github.com/IntelFsp suffice? Alternatively, I suspect it is feasible to setup the repo tool to pull github.com/IntelFsp at the same time it pulls the coreboot repo.

Thanks,

Nate

From: Patrick Georgi 
Date: Tuesday, July 10, 2018 at 11:38 PM
To: "Desimone, Nathaniel L" 
Cc: coreboot 
Subject: Re: [coreboot] Kaby Lake FSP

Nate, thank you for getting these things out and for the public update!

Could you please ask the lawyers if they consider 2.1 (b) and (c) of the license sufficient for unmodified redistribution (eg in the coreboot blobs repo: paths change, the files remain unmodified)? It seems like that should be possible, but since I'm just a software developer and they're the lawyers who wrote the license they ought to know.
That would make it easier to create FSP based configurations that build out of the box with the coreboot tree.

Thanks,
Patrick

Am Mi., 11. Juli 2018 um 03:06 Uhr schrieb Desimone, Nathaniel L :
Hi All,

I am a UEFI firmware architect working for Intel Corp. One of my focus areas is FSP. There was some prior discussion here regarding the lack of public updates for Kaby Lake FSP binaries and headers and questions regarding specialized FSP binaries being built for specific boards. I would like to clear up some of these questions and concerns. We just pushed all of the recently released versions of Kaby Lake FSP (3.1.0 through 3.6.0) to https://github.com/IntelFsp/FSP/tree/Kabylake. While there might appear to be forks of Kaby Lake FSP, they are actually just snapshots at different points in time. For example, there is one commit labelled as "Gold release for Kaby Lake FSP" that appears to be special fork for IoT devices... this commit is actually just Kaby Lake FSP Release 2.6.0 without any IoT specific modifications. Apologies for the confusing commit messages and for the temporary lapse in updates.

With Best Regards,

Nate

Kaby Lake FSP

[Nico Huber]

Hi,

On 11.07.2018 18:18, Desimone, Nathaniel L wrote:
> However, there is nothing in the license that prevents you from
> providing links to github.com/IntelFsp. It might not be exactly what you
> were hoping for but would adding a git submodule in coreboot blobs that
> points to github.com/IntelFsp suffice? Alternatively, I suspect it is
> feasible to setup the repo tool to pull github.com/IntelFsp at the same
> time it pulls the coreboot repo.

I had adding the Github repo as submodule in mind too as a fallback. One
downside is its structure, though, i.e. one branch per platform. This
means we'll have to maintain n submodule pointers for a single repo :-/

Nico

Kaby Lake FSP

[Desimone, Nathaniel L]

Hi Nico,

I don't have any opposition to reorganizing the repo to have one flat master branch with all the platforms in different folders.

- ApolloLakeFspBinPkg
- BayTrailFspBinPkg
- BraswellFspBinPkg
- BroadwellFspBinPkg
- KabylakeFspBinPkg
- SkylakeFspBinPkg
- etc.

That way you would only need 1 submodule. Would that work better for the coreboot community? I'll poll the Tianocore community, and other people at Intel as well to see if anyone else has inputs.

Thanks,

Nate

-----Original Message-----
From: Nico Huber [mailto:[e-mail]] 
Sent: Wednesday, July 11, 2018 9:39 AM
To: Desimone, Nathaniel L ; Patrick Georgi 
Cc: coreboot 
Subject: Re: [coreboot] Kaby Lake FSP

Hi,

On 11.07.2018 18:18, Desimone, Nathaniel L wrote:
> However, there is nothing in the license that prevents you from 
> providing links to github.com/IntelFsp. It might not be exactly what 
> you were hoping for but would adding a git submodule in coreboot blobs 
> that points to github.com/IntelFsp suffice? Alternatively, I suspect 
> it is feasible to setup the repo tool to pull github.com/IntelFsp at 
> the same time it pulls the coreboot repo.

I had adding the Github repo as submodule in mind too as a fallback. One downside is its structure, though, i.e. one branch per platform. This means we'll have to maintain n submodule pointers for a single repo :-/

Nico