[commit] r5451 - in trunk/util/vgabios: . include/console

[repository service]

Author: stepan
Date: Fri Apr 16 13:45:16 2010
New Revision: 5451
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5451

Log:
enable more warnings for vgabios utility, and enable some debugging 
Signed-off-by: Stefan Reinauer 
Acked-by: Stefan Reinauer

Modified:
   trunk/util/vgabios/Makefile
   trunk/util/vgabios/include/console/console.h

Modified: trunk/util/vgabios/Makefile
==============================================================================
--- trunk/util/vgabios/Makefile	Fri Apr 16 03:45:44 2010	(r5450)
+++ trunk/util/vgabios/Makefile	Fri Apr 16 13:45:16 2010	(r5451)
@@ -7,7 +7,12 @@
 #

CC       =  gcc
-CFLAGS   =  -Wall -Iinclude -I../../src/devices/oprom/include/ -O2 -g
+CFLAGS   = -O2 -g -fomit-frame-pointer
+CFLAGS  += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes
+CFLAGS  += -Wwrite-strings -Wredundant-decls -Wno-trigraphs 
+CFLAGS  += -Wstrict-aliasing -Wshadow -Wextra
+
+INCLUDES = -Iinclude -I../../src/devices/oprom/include/

INTOBJS  = int10.o int15.o int16.o int1a.o inte6.o
 X86EMUOBJS  = sys.o decode.o ops.o ops2.o prim_ops.o fpu.o debug.o
@@ -29,5 +34,8 @@
    rm -f *.o *~ testbios

%.o: ../../src/devices/oprom/x86emu/%.c
-	$(CC) $(CFLAGS) -include stdio.h -c -o $@ $^
+	$(CC) $(CFLAGS) $(INCLUDES) -include stdio.h -c -o $@ $^
+
+%.o: %.c
+	$(CC) $(CFLAGS) $(INCLUDES) -c -o $@ $<

Modified: trunk/util/vgabios/include/console/console.h
==============================================================================
--- trunk/util/vgabios/include/console/console.h	Fri Apr 16 03:45:44 2010	(r5450)
+++ trunk/util/vgabios/include/console/console.h	Fri Apr 16 13:45:16 2010	(r5451)
@@ -1,3 +1,4 @@
 #ifndef _CONSOLE_CONSOLE_H
 #define _CONSOLE_CONSOLE_H
+#define CONFIG_X86EMU_DEBUG 1
 #endif

[commit] r5451 - in trunk/util/vgabios: . include/console

[Myles Watson]

> Log:
> enable more warnings for vgabios utility, and enable some debugging
> Signed-off-by: Stefan Reinauer 
> Acked-by: Stefan Reinauer
>
> Modified:
>    trunk/util/vgabios/Makefile
>    trunk/util/vgabios/include/console/console.h
> Modified: trunk/util/vgabios/include/console/console.h
>
> ====
> --- trunk/util/vgabios/include/console/console.h	Fri Apr 16 03:45:44
> 2010	(r5450)
> +++ trunk/util/vgabios/include/console/console.h	Fri Apr 16 13:45:16
> 2010	(r5451)
> @@ -1,3 +1,4 @@
>  #ifndef _CONSOLE_CONSOLE_H
>  #define _CONSOLE_CONSOLE_H
> +#define CONFIG_X86EMU_DEBUG 1

If this is a config variable it should be set in Kconfig.  If it isn't, it
should probably have a different name.

Thanks,
Myles

[commit] r5451 - in trunk/util/vgabios: . include/console

[Stefan Reinauer]

On 4/16/10 2:43 PM, Myles Watson wrote:
> > Modified: trunk/util/vgabios/include/console/console.h
> >
> > ====
> > --- trunk/util/vgabios/include/console/console.h	Fri Apr 16 03:45:44
> > 2010	(r5450)
> > +++ trunk/util/vgabios/include/console/console.h	Fri Apr 16 13:45:16
> > 2010	(r5451)
> > @@ -1,3 +1,4 @@
> >  #ifndef _CONSOLE_CONSOLE_H
> >  #define _CONSOLE_CONSOLE_H
> > +#define CONFIG_X86EMU_DEBUG 1
>
> If this is a config variable it should be set in Kconfig.  If it isn't, it
> should probably have a different name.

It's a utility completely independent of coreboot (well, supposed to
be), just sharing some code. So I think it should not depend on the
coreboot Kconfig. But I didn't want to add a separate Kconfig build
system either, so I just hard coded the one variable...

[commit] r5451 - in trunk/util/vgabios: . include/console

[Myles Watson]

On Fri, Apr 16, 2010 at 4:49 PM, Stefan Reinauer wrote:
> On 4/16/10 2:43 PM, Myles Watson wrote:
> > > Modified: trunk/util/vgabios/include/console/console.h
>
> ==========================================================================
> > > ====
> > > --- trunk/util/vgabios/include/console/console.h     Fri Apr 16 03:45:44
> > > 2010 (r5450)
> > > +++ trunk/util/vgabios/include/console/console.h     Fri Apr 16 13:45:16
> > > 2010 (r5451)
> > > @@ -1,3 +1,4 @@
> > >  #ifndef _CONSOLE_CONSOLE_H
> > >  #define _CONSOLE_CONSOLE_H
> > > +#define CONFIG_X86EMU_DEBUG 1
> >
> > If this is a config variable it should be set in Kconfig.  If it isn't,
>
> it
> > should probably have a different name.
>
> It's a utility completely independent of coreboot (well, supposed to
> be), just sharing some code. So I think it should not depend on the
> coreboot Kconfig. But I didn't want to add a separate Kconfig build
> system either, so I just hard coded the one variable...

Sorry about that.  I should have looked more closely at the path.  Since
x86_emu used to be in util ...

Thanks for straightening me out,
Myles