[commit] r6113 - trunk/src/console

[repository service]

Author: oxygene
Date: Mon Nov 22 14:07:10 2010
New Revision: 6113
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6113

Log:
Workaround to get die.c to work with romcc.

Signed-off-by: Patrick Georgi 
Acked-by: Patrick Georgi

Modified:
   trunk/src/console/die.c

Modified: trunk/src/console/die.c
==============================================================================
--- trunk/src/console/die.c	Mon Nov 22 13:59:36 2010	(r6112)
+++ trunk/src/console/die.c	Mon Nov 22 14:07:10 2010	(r6113)
@@ -23,8 +23,14 @@
 #include <arch/hlt.h>
 #include <console/console.h>

+#ifndef __ROMCC__
+#define NORETURN __attribute__((noreturn))
+#else
+#define NORETURN
+#endif
+
 /* Report a fatal error */
-void __attribute__((noreturn)) die(const char *msg)
+void NORETURN die(const char *msg)
 {
    print_emerg(msg);
    do {

[Stefan Reinauer]

* repository service  [101122 14:07]:
> Author: oxygene
> Date: Mon Nov 22 14:07:10 2010
> New Revision: 6113
> URL: https://tracker.coreboot.org/trac/coreboot/changeset/6113
>
> Log:
> Workaround to get die.c to work with romcc.
>
> Signed-off-by: Patrick Georgi 
> Acked-by: Patrick Georgi
>
> Modified:
>    trunk/src/console/die.c

ouch, thanks for fixing this. Not sure how my tree could survive abuild
in the first place. Didn't we add attribute((noreturn)) (fake) support
to romcc at some point?

Maybe we should.

[Patrick Georgi]

Am 22.11.2010 19:32, schrieb Stefan Reinauer:
> Didn't we add attribute((noreturn)) (fake) support
> to romcc at some point?

There is _some_ support, but it's rather fragile, and I didn't find the
correct incantation immediately, so I opted to drop it for now.

Patrick