[LinuxBIOS] [PATCH] trivial Options.lb patch for serengeti-cheetah

[Myles Watson]

This patch adds this line to src/mainboard/amd/serengeti_cheetah/Options.lb:

uses CONFIG_PRECOMPRESSED_PAYLOAD

[LinuxBIOS] [PATCH] trivial Options.lb patch for serengeti-cheetah

[Corey Osgood]

Myles Watson wrote:
> This patch adds this line to src/mainboard/amd/serengeti_cheetah/Options.lb:
>
> uses CONFIG_PRECOMPRESSED_PAYLOAD

For what purpose? abuild or buildrom? Needs a signed-off-by line as
well, no matter how trivial.

-Corey

[LinuxBIOS] [PATCH] trivial Options.lb patch for serengeti-cheetah

[Ward Vandewege]

On Wed, Nov 07, 2007 at 11:57:53AM -0500, Corey Osgood wrote:
> Myles Watson wrote:
> > This patch adds this line to src/mainboard/amd/serengeti_cheetah/Options.lb:
> >
> > uses CONFIG_PRECOMPRESSED_PAYLOAD
>
> For what purpose? abuild or buildrom? Needs a signed-off-by line as

Presumably to make the LZMA compression option work in buildrom. I've had to
add the same to the boards I've added to buildrom.

Thanks,
Ward.

[LinuxBIOS] [PATCH] trivial Options.lb patch for serengeti-cheetah

[Myles Watson]

On 11/7/07, Ward Vandewege  wrote:
> On Wed, Nov 07, 2007 at 11:57:53AM -0500, Corey Osgood wrote:
> > For what purpose? abuild or buildrom? Needs a signed-off-by line as
>
> Presumably to make the LZMA compression option work in buildrom. I've had to
> add the same to the boards I've added to buildrom.

Yes. Here it is again.
Is there some reason to economize uses statements?  It seems like this
one should be in all the Options.lb files.

Signed-off-by: Myles Watson 
Thanks,
Myles

[LinuxBIOS] [PATCH] trivial Options.lb patch for serengeti-cheetah

[Ward Vandewege]

On Wed, Nov 07, 2007 at 10:05:40AM -0700, Myles Watson wrote:
> On 11/7/07, Ward Vandewege  wrote:
> > On Wed, Nov 07, 2007 at 11:57:53AM -0500, Corey Osgood wrote:
> > > For what purpose? abuild or buildrom? Needs a signed-off-by line as
> >
> > Presumably to make the LZMA compression option work in buildrom. I've had to
> > add the same to the boards I've added to buildrom.
>
> Yes. Here it is again.
> Is there some reason to economize uses statements?  It seems like this
> one should be in all the Options.lb files.

I can't see why not. Any other opinions?
> Signed-off-by: Myles Watson

Acked-by: Ward Vandewege

committed in r2950.

Thanks,
Ward.

[LinuxBIOS] [PATCH] trivial Options.lb patch for serengeti-cheetah

[Ward Vandewege]

On Wed, Nov 07, 2007 at 09:38:30AM -0700, Myles Watson wrote:
> This patch adds this line to src/mainboard/amd/serengeti_cheetah/Options.lb:
>
> uses CONFIG_PRECOMPRESSED_PAYLOAD

Please add a signed-off-by line. When you do that:

Acked-by: Ward Vandewege

Thanks,
Ward.