[rfc] ACPI cleanup proposal

[Cristian Măgherușan-Stanciu]

Hello,

Please find attached a diff that contains my work done during the
hackathon in Prague. The motherboard code that creates ACPi is
cleaner, as you can see on the Asus M2V-MX-SE code modified as a
reference.

For some reasons the motherboard failed to boot after I applied it, so
most likely there is a bug which needs to be fixed.

I don't have access to the mainboard anymore (it was Ruik's) and I
will only have access to mine in a month or so, so I thought that I
should send the code as a RFC, maybe someone will be able to figure it
out sooner than that and why not port it to other boards if
appropriate.

Cheers,
Cristi

[Cristian Măgherușan-Stanciu]

I found a few issues in the patch, please try the one attached to this
message instead.
Sorry for the clumsiness.

~Cristi

[Mark Marshall]

On 02/06/2011 19:20, Cristian Măgherușan-Stanciu wrote:
> I found a few issues in the patch, please try the one attached to this
> message instead.
> Sorry for the clumsiness.
>
> ~Cristi

Hi.

In the new functions, all of the form acpi_write_foo, there is a pointer 
passed in that is of type acpi_header_t, called foo.  This "in" 
parameter is then set to a value by the new function?  This doesn't seem 
to be correct - either the acpi_header_t * variable should be local to 
the function or it should be a "in/out" parameter?

(I think dsdt, for instance, should be in/out.  hpet should be local to 
acpi_write_hpet).

MM