I see no reason why we'd want to include ../../x86/mtrr _twice_ in a Makefile.inc, but if there are reasons for that we should definately document them.
Uwe.
Uwe Hermann wrote:
subdirs-y += ../../x86/tsc -subdirs-y += ../../x86/mtrr subdirs-y += ../../x86/fpu subdirs-y += ../../x86/mmx subdirs-y += ../../x86/sse
Could these last two be set in cpu/x86 by CONFIG_{MMX,SSE} ?
//Peter
Peter Stuge wrote:
Uwe Hermann wrote:
subdirs-y += ../../x86/tsc -subdirs-y += ../../x86/mtrr subdirs-y += ../../x86/fpu subdirs-y += ../../x86/mmx subdirs-y += ../../x86/sse
Could these last two be set in cpu/x86 by CONFIG_{MMX,SSE} ?
That, or dropped.. They're noops, really.
Stefan Reinauer wrote:
subdirs-y += ../../x86/tsc -subdirs-y += ../../x86/mtrr subdirs-y += ../../x86/fpu subdirs-y += ../../x86/mmx subdirs-y += ../../x86/sse
Could these last two be set in cpu/x86 by CONFIG_{MMX,SSE} ?
That, or dropped.. They're noops, really.
Right, because {en,dis}able_{mmx,sse}.inc are included explicitly.
enable_mmx.inc has two comments. See patch. disable_mmx.inc has one instruction. Huge overhead for that.
//Peter
On Fri, Oct 16, 2009 at 05:31:09AM +0200, Peter Stuge wrote:
Drop enable_mmx.inc. It reads (only) "Enabling mmx registers is a noop"
Signed-off-by: Peter Stuge peter@stuge.se
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Uwe.
Uwe Hermann wrote:
Drop enable_mmx.inc. It reads (only) "Enabling mmx registers is a noop"
Signed-off-by: Peter Stuge peter@stuge.se
Acked-by: Uwe Hermann uwe@hermann-uwe.de
r4791
On Fri, Oct 16, 2009 at 05:43:46AM +0200, Peter Stuge wrote:
Drop empty cpu/x86/{mmx,sse}/Makefile.inc
Signed-off-by: Peter Stuge peter@stuge.se
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Please also drop the empty Config.lb and Makefile.inc files (after checking that abuild won't break).
Uwe.
[rminnich@amd64 coreboot-v2]$ ls src/cpu/x86/mmx/ Config.lb disable_mmx.inc enable_mmx.inc Makefile.inc [rminnich@amd64 coreboot-v2]$ ls src/cpu/x86/sse Config.lb disable_sse.inc enable_sse.inc Makefile.inc [rminnich@amd64 coreboot-v2]$
great to get rid of the unnecessary Config.lb/Makefile.inc files. But we'll still have two directories to hold 3 files!
And the name is mmx/disable_mmx.c? We repeat mmx twice. Could we just remove the directories and put the files in src/cpu/x86/?
In fact why not just remove all the subdirs? I just looked and there are many dirs with one source file, or two. And the files in many cases have the directory name in them anyway ... These many directories are confusing and overkill, really.
ron
ron minnich wrote:
remove the directories and put the files in src/cpu/x86/?
I started doing that already, but wanted to start with the simplest patches. :)
In fact why not just remove all the subdirs? I just looked and there are many dirs with one source file, or two. And the files in many cases have the directory name in them anyway ... These many directories are confusing and overkill, really.
Agree completely.
//Peter
Uwe Hermann wrote:
Drop empty cpu/x86/{mmx,sse}/Makefile.inc
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Please also drop the empty Config.lb and Makefile.inc files (after checking that abuild won't break).
It was abuild tested. r4792
Uwe Hermann wrote:
Drop duplicate CPU subdirs-y entries for "../../x86/mtrr".
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Peter Stuge peter@stuge.se
On Fri, Oct 16, 2009 at 05:46:37AM +0200, Peter Stuge wrote:
Uwe Hermann wrote:
Drop duplicate CPU subdirs-y entries for "../../x86/mtrr".
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Peter Stuge peter@stuge.se
Thanks, r4784.
Uwe.
-
Peter Stuge -
ron minnich -
Stefan Reinauer -
Uwe Hermann