[PATCH] Filter out a few more

[Myles Watson]

Signed-off-by: Myles Watson

Thanks,
Myles

[Patrick Georgi]

Am Montag, den 12.10.2009, 13:58 -0600 schrieb Myles Watson:
> Signed-off-by: Myles Watson

+       -e "/^CONFIG_HAVE_MP_TABLE / d" \
+       -e "/^CONFIG_HAVE_PIRQ_TABLE / d" \
+       -e "/^CONFIG_HAVE_ACPI_TABLES / d" \
Why do you want to exclude these from comparison?

+       -e "/^CONFIG_IDE / d" \
that one is a curious case: it seems to be about the ide stream loader
thingy (which doesn't really exist anymore), but it seems to be
repurposed for some IDE drivers
In src/southbridge/intel/i82801ca/Makefile.inc:
driver-$(CONFIG_IDE) += i82801ca_ide.o

Maybe that should be changed, and CONFIG_IDE be ignored

Regards,
Patrick

[Myles Watson]

> Am Montag, den 12.10.2009, 13:58 -0600 schrieb Myles Watson:
> > Signed-off-by: Myles Watson
>   -e "/^CONFIG_HAVE_MP_TABLE / d" \
>   -e "/^CONFIG_HAVE_PIRQ_TABLE / d" \
>   -e "/^CONFIG_HAVE_ACPI_TABLES / d" \
>
> Why do you want to exclude these from comparison?

They are options, and they aren't selected automatically by kbuildall.
Without the distinction between HAVE_ and GEN_ it would be an error to force
boards to build all the tables they have.
>   -e "/^CONFIG_IDE / d" \
>
> that one is a curious case: it seems to be about the ide stream loader
> thingy (which doesn't really exist anymore), but it seems to be
> repurposed for some IDE drivers
> In src/southbridge/intel/i82801ca/Makefile.inc:
> driver-$(CONFIG_IDE) += i82801ca_ide.o

OK.  I didn't see that.

Thanks,
Myles

[ron minnich]

On Tue, Oct 13, 2009 at 5:39 AM, Myles Watson  wrote:
> > Am Montag, den 12.10.2009, 13:58 -0600 schrieb Myles Watson:
> > > Signed-off-by: Myles Watson
> > -e "/^CONFIG_HAVE_MP_TABLE / d" \
> > -e "/^CONFIG_HAVE_PIRQ_TABLE / d" \
> > -e "/^CONFIG_HAVE_ACPI_TABLES / d" \
> >
> > Why do you want to exclude these from comparison?
>
> They are options, and they aren't selected automatically by kbuildall.
> Without the distinction between HAVE_ and GEN_ it would be an error to force
> boards to build all the tables they have.
> > -e "/^CONFIG_IDE / d" \
> >
> > that one is a curious case: it seems to be about the ide stream loader
> > thingy (which doesn't really exist anymore), but it seems to be
> > repurposed for some IDE drivers
> > In src/southbridge/intel/i82801ca/Makefile.inc:
> > driver-$(CONFIG_IDE) += i82801ca_ide.o
>
> OK.  I didn't see that.

we had problems in the past where a vendor would have a southbridge
with IDE but add a different chip for IDE. So you had to know whether
to enable the SB ide or the other IDE. I've seen this several times.

CONFIG_IDE kind of fails for this purpose because there might be
multiple parts on the board with IDE and you will end up compiling
them all in. It's going to enable anything that has an IDE and has
this conditional compilation, even if there is a conflict, I think.
But we might need that i82801ca_ide code just so we can disable IDE!
That happens too ...

I think this should be a -y and I think CONFIG_IDE should die. If we
need conditional inclusion of this code, why not
CONFIG_SOUTHBRIDGE_INTEL_I82801ER_IDE? But CONFIG_IDE was really for
the now-removed IDE streams, and it has been incorrectly used for a
different purpose.

ron