artecgroup/dbe62: Remove a stale useless dumplxmsrs call and touch up a comment
The dumplxmsrs call, that this change removes, is done before raminit even sets those regs to something useful
Signed-off-by: Mart Raudsepp mart.raudsepp@artecdesign.ee --- mainboard/artecgroup/dbe62/initram.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/mainboard/artecgroup/dbe62/initram.c b/mainboard/artecgroup/dbe62/initram.c index aebefc3..97b75bb 100644 --- a/mainboard/artecgroup/dbe62/initram.c +++ b/mainboard/artecgroup/dbe62/initram.c @@ -116,15 +116,13 @@ static void mb_gpio_init(void) }
/** - * main for initram for the PC Engines Alix 1C. It might seem that you - * could somehow do these functions in, e.g., the cpu code, but the + * main for initram for the Artec Group ThinCan DBE62. It might seem that + * you could somehow do these functions in, e.g., the cpu code, but the * order of operations and what those operations are is VERY strongly * mainboard dependent. It's best to leave it in the mainboard code. */ int main(void) { - void dumplxmsrs(void); - printk(BIOS_DEBUG, "Hi there from stage1\n"); post_code(POST_START_OF_MAIN);
On 14.11.2008 16:29, Mart Raudsepp wrote:
artecgroup/dbe62: Remove a stale useless dumplxmsrs call and touch up a comment
The dumplxmsrs call, that this change removes, is done before raminit even sets those regs to something useful
I can't see a dumplxmsrs call, only a function prototype.
Signed-off-by: Mart Raudsepp mart.raudsepp@artecdesign.ee
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
Ühel kenal päeval, R, 2008-11-14 kell 16:35, kirjutas Carl-Daniel Hailfinger:
On 14.11.2008 16:29, Mart Raudsepp wrote:
artecgroup/dbe62: Remove a stale useless dumplxmsrs call and touch up a comment
The dumplxmsrs call, that this change removes, is done before raminit even sets those regs to something useful
I can't see a dumplxmsrs call, only a function prototype.
Function prototypes in other function bodies should be banned from the C language :)
Lets try the attached patch instead
-- Mart Raudsepp
Mart Raudsepp wrote:
I see no reason to have these memory work related debug calls commented out in the code, everyone should know what to locally temporarily add to debug this.
Signed-off-by: Mart Raudsepp mart.raudsepp@artecdesign.ee
Acked-by: Peter Stuge peter@stuge.se
-
Carl-Daniel Hailfinger -
Mart Raudsepp -
Peter Stuge