New patch to review for coreboot: f135193 More descriptive error messages in Sandybridge raminit code

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1289

-gerrit

commit f1351932d41879cf8b71e8586667ba1ab5ac70c7
Author: Stefan Reinauer 
Date:   Mon Jun 18 14:38:40 2012 -0700

More descriptive error messages in Sandybridge raminit code

MRC returns specific error codes; print the according error
    message if we know what it means.

Change-Id: Iaaf1512b9d577d4291fccfb94d879043ab5b11b5
    Signed-off-by: Stefan Reinauer 
---
 src/northbridge/intel/sandybridge/raminit.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 0df86d6..bb8b25c 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -249,8 +249,17 @@ void sdram_initialize(struct pei_data *pei_data)
    		      "call *%%ecx\n\t"
    		      :"=a" (rv) : "c" (entry), "a" (pei_data));
    	if (rv) {
-			printk(BIOS_ERR, "MRC returned %x\n", rv);
-			die("Nonzero MRC return value\n");
+			switch (rv) {
+			case -1:
+				printk(BIOS_ERR, "PEI version mismatch.");
+				break;
+			case -2:
+				printk(BIOS_ERR, "Invalid memory frequency.\n");
+				break;
+			default:
+				printk(BIOS_ERR, "MRC returned %x.\n", rv);
+			}
+			die("Nonzero MRC return value.\n");
    	}
    } else {
    	die("UEFI PEI System Agent not found.\n");