[LinuxBIOS] [PATCH] v3: Move htl() into cpu.h

[Uwe Hermann]

See patch.

Do we really need or want the "__attribute__((always_inline))"? If so we
probably want it for quite a bunch of other functions, too...

Uwe.

[LinuxBIOS] [PATCH] v3: Move htl() into cpu.h

[ron minnich]

On 6/30/07, Uwe Hermann  wrote:
> See patch.
>
> Do we really need or want the "__attribute__((always_inline))"?

Only rarely.

Why we would need it for hlt()? So, in case memory is totally not
working, we don't do a call and try to push stuff on a stack. We want
it inline.

There are very few cases where we should apply always_inline.

ron

[LinuxBIOS] [PATCH] v3: Move htl() into cpu.h

[Uwe Hermann]

On Sat, Jun 30, 2007 at 02:35:04PM -0700, ron minnich wrote:
> On 6/30/07, Uwe Hermann  wrote:
> > See patch.
> >
> > Do we really need or want the "__attribute__((always_inline))"?
>
> Only rarely.
>
> Why we would need it for hlt()? So, in case memory is totally not
> working, we don't do a call and try to push stuff on a stack. We want
> it inline.
>
> There are very few cases where we should apply always_inline.

OK, I see, thanks. Patch updated.

Uwe.