RE: FYI: Merge in progress...

[YhLu]

Comment out disable_cache and enabe_cache in amd_early_mtrr_init you will
get 5s speed up.

I checked old amd_early_mtrr.inc, it seems it only has enable cache, but no
wbinvd.

Regards

YH

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] 
Sent: Wednesday, October 20, 2004 12:50 PM
To: YhLu
Cc: Li-Ta Lo; 'Ronald G. Minnich'; 'LinuxBIOS'
Subject: Re: FYI: Merge in progress...

YhLu  writes:
> Why enable cache in amd_early_mtrr_init?

Usually that is a speed up.  I think all I changed was using the C
implementation.
Previously the assembly was called from Config.lb.
> That causes CPU sleep 5s again.

That is peculiar.
> After get rid of that, the new auto.c stage still cost more 1s than the

code
> two weeks ago.

Hmm.

This is certainly worth fixing.  And it tends to explain why I have
not yet seen the 5s speed up.

Eric

FYI: Merge in progress...

YhLu  writes:
> Comment out disable_cache and enabe_cache in amd_early_mtrr_init you will
> get 5s speed up.
>
> I checked old amd_early_mtrr.inc, it seems it only has enable cache, but no
> wbinvd.

Right.  At the time I had no clue invalidates were a problem.

I have just removed the wbinvd, it was just there for good measure.

Eric