undefined reference to `IS_PC_SLICE_TYPE_BSD'

[BeBa]

HI,
this is my first try at compiling filo. the latest versions downloaded
with svn co.

google shows one issue already reported. Is this something new? How to
circumvent this barrier?

thanks
BenBa

/>make CC="gcc -m32" LD="ld -b elf32-i386" HOSTCC="gcc" AS="as --32"
Found
Libpayload /home/kb2qzv/subversion/coreboot/payloads/filo/build/libpayload/lib/libpayload.a.
CC      build/i386/context.o CC      build/i386/segment.o
  CC      build/i386/timer.o
  CC      build/i386/sys_info.o
  CC      build/i386/linux_load.o
  CC      build/main/filo.o
  CC      build/main/strtox.o
  CC      build/main/elfload.o
  CC      build/main/ipchecksum.o
  CC      build/main/grub/grub.o
  CC      build/main/grub/builtins.o
  CC      build/main/grub/cmdline.o
  CC      build/main/grub/char_io.o
  CC      build/main/grub/completions.o
  CC      build/fs/blockdev.o
  CC      build/fs/vfs.o
  CC      build/fs/eltorito.o
  CC      build/fs/fsys_ext2fs.o
  CC      build/fs/fsys_fat.o
  CC      build/fs/fsys_reiserfs.o
  CC      build/fs/fsys_iso9660.o
  CC      build/fs/fsys_cbfs.o
  CC      build/fs/cbfs.o
  CC      build/fs/lzma.o
  CC      build/drivers/ide.o
  CC      build/drivers/usb.o
  CC      build/drivers/intel.o
  LD      build/filo
/home/kb2qzv/subversion/coreboot/payloads/filo/build/main/grub/completions.o:
In function `print_completions': completions.c:(.text+0x2f2): undefined
reference to `IS_PC_SLICE_TYPE_BSD' make: ***
[/home/kb2qzv/subversion/coreboot/payloads/filo/build/filo] Error 1

[BeBa]

As a follow-up to my own post, I found out that taking out the GRUB
option from the config file lets the compilation go through:
(# CONFIG_USE_GRUB is not set)

make CC="gcc -m32" LD="ld -b elf32-i386" HOSTCC="gcc" AS="as --32"
building libpayload.
make[1]: Entering directory
`/home/kb2qzv/subversion/coreboot/payloads/libpayload' make[1]: Leaving
directory `/home/kb2qzv/subversion/coreboot/payloads/libpayload'
make[1]: Entering directory
`/home/kb2qzv/subversion/coreboot/payloads/libpayload' *
* libpayload Configuration
*
*
* Generic Options
*
Experimental Options (EXPERIMENTAL) [N/y/?] n
Obsolete Options (OBSOLETE) [N/y/?] n
Developer Options (DEVELOPER) [N/y/?] n
*
* Architecture Options
*
Target Architecture
> x86 (TARGET_I386)

2. PowerPC (TARGET_POWERPC)
choice[1-2]: 1
Multiboot header support (MULTIBOOT) [Y/n] y
*
* Standard Libraries
*
Enable C library support (LIBC) [Y/n] y
Enable tinycurses support (TINYCURSES) [Y/n] y
CBFS support (CBFS) [N/y/?] n
*
* Console Options
*
See output on the serial port console (SERIAL_CONSOLE) [Y/n] y
  I/O base for the serial port (default 0x3f8) (SERIAL_IOBASE) [0x3f8]
0x3f8 Override the serial console baud rate (SERIAL_SET_SPEED) [N/y] n
  Use plain ASCII characters for ACS (SERIAL_ACS_FALLBACK) [N/y/?] n
See output on a video console (VIDEO_CONSOLE) [Y/n] y
  VGA video console driver (VGA_VIDEO_CONSOLE) [Y/n] y
  Geode LX video console driver (GEODELX_VIDEO_CONSOLE) [N/y] n
    coreboot video console driver (COREBOOT_VIDEO_CONSOLE) [N/y/?] n
Allow input from a PC keyboard (PC_KEYBOARD) [Y/n] y
  English (US) keyboard layout (PC_KEYBOARD_LAYOUT_US) [Y/n] y
  German keyboard layout (PC_KEYBOARD_LAYOUT_DE) [N/y] n
*
* Drivers
*
Support for PCI devices (PCI) [Y/n] y
Support for reading/writing NVRAM bytes (NVRAM) [Y/n] y
Extended RTC ports are 0x74/0x75 (RTC_PORT_EXTENDED_VIA) [N/y/?] n
Support for PC speaker (SPEAKER) [Y/n] y
USB Support (USB) [Y/n] y
  Support for USB UHCI controllers (USB_UHCI) [N/y/?] n
  Support for USB OHCI controllers (USB_OHCI) [N/y/?] n
  Support for USB EHCI controllers (USB_EHCI) [N/y/?] n
  Support for USB xHCI controllers (USB_XHCI) [N/y/?] n
  Support for USB keyboards (USB_HID) [Y/n/?] y
  Support for USB hubs (USB_HUB) [Y/n/?] y
  Support for USB storage (USB_MSC) [Y/n/?] y
#
# configuration written to .config
#
make[1]: Leaving directory
`/home/kb2qzv/subversion/coreboot/payloads/libpayload' make[1]:
Entering directory
`/home/kb2qzv/subversion/coreboot/payloads/libpayload' CC
build/arch/i386/head.S.o CC      build/arch/i386/main.o CC
build/arch/i386/sysinfo.o CC      build/arch/i386/timer.o
  CC      build/arch/i386/coreboot.o
  CC      build/arch/i386/util.S.o
  CC      build/arch/i386/exec.S.o
  CC      build/arch/i386/virtual.o
  CC      build/arch/i386/multiboot.o
  CC      build/crypto/sha1.o
  CC      build/libc/malloc.o
  CC      build/libc/printf.o
  CC      build/libc/console.o
  CC      build/libc/string.o
  CC      build/libc/memory.o
  CC      build/libc/ctype.o
  CC      build/libc/ipchecksum.o
  CC      build/libc/lib.o
  CC      build/libc/rand.o
  CC      build/libc/time.o
  CC      build/libc/exec.o
  CC      build/libc/readline.o
  CC      build/libc/getopt_long.o
  CC      build/libc/sysinfo.o
  CC      build/libc/args.o
  CC      build/drivers/pci.o
  CC      build/drivers/speaker.o
  CC      build/drivers/serial.o
  CC      build/drivers/keyboard.o
  CC      build/drivers/nvram.o
  CC      build/drivers/options.o
  CC      build/drivers/video/video.o
  CC      build/drivers/video/vga.o
  CC      build/drivers/usb/usbinit.o
  CC      build/drivers/usb/usb.o
  CC      build/drivers/usb/usb_dev.o
  CC      build/drivers/usb/quirks.o
  CC      build/drivers/usb/usbhub.o
  CC      build/drivers/usb/usbhid.o
  CC      build/drivers/usb/usbmsc.o
  CC      build/drivers/hid.o
  CC      build/libpci/libpci.o
  CC      build/curses/keyboard.o
  CC      build/curses/tinycurses.o
  CC      build/curses/colors.o
  AR      build/lib/libpayload.a
  CP      build/lib/i386/head.o
  INSTALL /home/kb2qzv/subversion/coreboot/payloads/filo/build/libpayload/lib
  INSTALL /home/kb2qzv/subversion/coreboot/payloads/filo/build/libpayload/include
  INSTALL /home/kb2qzv/subversion/coreboot/payloads/filo/build/libpayload/bin
make[1]: Leaving directory
`/home/kb2qzv/subversion/coreboot/payloads/libpayload' CC
build/i386/context.o AS      build/i386/switch.S.o
  CC      build/i386/segment.o
  CC      build/i386/timer.o
  CC      build/i386/sys_info.o
  CC      build/i386/linux_load.o
  CC      build/main/filo.o
  CC      build/main/strtox.o
  CC      build/main/elfload.o
  CC      build/main/ipchecksum.o
  CC      build/main/sound.o
  CC      build/fs/blockdev.o
  CC      build/fs/vfs.o
  CC      build/fs/eltorito.o
  CC      build/fs/fsys_ext2fs.o
  CC      build/fs/fsys_fat.o
  CC      build/fs/fsys_iso9660.o
  CC      build/fs/fsys_squashfs.o
  CC      build/fs/squashfs_zlib.o
  CC      build/drivers/ide.o
  CC      build/drivers/via-sound.o
  CC      build/drivers/usb.o
  CC      build/drivers/intel.o
  LD      build/filo
  STRIP   build/filo.elf

Trouble is how to include USE_GRUB?

BenBa

undefined reference to `IS_PC_SLICE_TYPE_BSD' SOLVED

[BeBa]

Hi,
I did what one of the authors said to do and it really compiles without
previous error.

One has to:
while in payloads/filo

cd main/grub/
nano -w completions.c
add line 25:
#define IS_PC_SLICE_TYPE_BSD_WITH_FS(type,fs) 0

go to line 205 and change it into:
&& ! IS_PC_SLICE_TYPE_BSD_WITH_FS(current_slice,0)) {

Save and recompile.

It should work.

If I may suggest why don't someone look into it whether this has been
the right way to fix it...

thanks in advance

BenBa