RE: [LinuxBIOS] Merge complete....

[YhLu]

if(is_cpu_d0()) {
                /* Erratum 110 ...*/
                msr = rdmsr_amd(CPU_ID_HYPER_EXT_FEATURES);
                msr.hi |=1;
                wrmsr_amd(CPU_ID_HYPER_EXT_FEATURES, msr);
        }

if (is_cpu_pre_e0()) {
                /* Erratum 110 ... */
                msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR);
                msr.hi |=1;
                wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr);
        }

also in model_fxx_init.c you miss sth
should be

if(is_cpu_d0()) {
                /* Erratum 110 ...*/
                msr = rdmsr_amd(CPU_ID_HYPER_EXT_FEATURES);
                msr.hi |=1;
                wrmsr_amd(CPU_ID_HYPER_EXT_FEATURES, msr);
        }

if (!is_cpu_pre_e0()) {  ------------------------------don't forget
!
                /* Erratum 110 ... */
                msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR);
                msr.hi |=1;
                wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr);
        }

YH
> -----Original Message-----
> From: Li-Ta Lo [mailto:[e-mail]] 
> Sent: Wednesday, June 22, 2005 11:40 AM
> To: YhLu
> Cc: LinuxBIOS
> Subject: RE: [LinuxBIOS] Merge complete....
>
> On Wed, 2005-06-22 at 12:34 -0600, Li-Ta Lo wrote:
> > On Wed, 2005-06-22 at 11:29 -0700, YhLu wrote:
> > > define HARD_RESET_BUS
> > >
> > > removed, Good, get amd8111 bus from config_bus_map...
> >
> > Eric,
> >
> > Is there any reason you put reset.c in every mainboard
>
> directory but
> > the only thing in these reset.c is #include "amd8111_reset.c" ?
>
> And node_link_to_bus in amd8111_reset.c and every auto.c?

[LinuxBIOS] Merge complete....

YhLu  writes:
>     if(is_cpu_d0()) {
>             /* Erratum 110 ...*/
>             msr = rdmsr_amd(CPU_ID_HYPER_EXT_FEATURES);
>             msr.hi |=1;
>             wrmsr_amd(CPU_ID_HYPER_EXT_FEATURES, msr);
>     }
>
>     if (is_cpu_pre_e0()) {
>             /* Erratum 110 ... */
>             msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR);
>             msr.hi |=1;
>             wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr);
>     }
>
> also in model_fxx_init.c you miss sth
> should be
>     if(is_cpu_d0()) {
>             /* Erratum 110 ...*/
>             msr = rdmsr_amd(CPU_ID_HYPER_EXT_FEATURES);
>             msr.hi |=1;
>             wrmsr_amd(CPU_ID_HYPER_EXT_FEATURES, msr);
>     }
>
>     if (!is_cpu_pre_e0()) {  ------------------------------don't forget
>
> !
>                 /* Erratum 110 ... */
>                 msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR);
>                 msr.hi |=1;
>                 wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr);
>         }

Good catch.  That was a recent case where I had to merge by hand I guess I was
tired when I did that one.

Eric