#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA functions.

[coreboot]

#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA
functions.
--------------------------------------------+-------------------------------
    Reporter:  edwin_beasant@…              |         Owner:  stepan@…             
        Type:  defect                       |        Status:  new                  
    Priority:  major                        |     Milestone:  Going mainstream     
   Component:  coreboot                     |      Keywords:  Geode VSA option rom 
Dependencies:                               |   Patchstatus:  there is no patch    
--------------------------------------------+-------------------------------
 For some reason, the VSA running code has been moved to the option rom
 source files - this is not usable when I don't wish coreboot to run the
 option roms on the system (I want seabios to do it).

Compilation fails trying to find do_vsmbios.
 reporting:

build/coreboot_ram.o: In function `pci_domain_enable':
 northbridge.c:(.text+0xd44): undefined reference to `do_vsmbios'
 collect2: ld returned 1 exit status
 make: *** [build/coreboot_ram] Error 1

This code needs to be independent of running option roms or not.

[coreboot]

#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA
functions.
--------------------------------------------+-------------------------------
    Reporter:  edwin_beasant@…              |         Owner:  stepan@…             
        Type:  defect                       |        Status:  new                  
    Priority:  major                        |     Milestone:  Going mainstream     
   Component:  coreboot                     |      Keywords:  Geode VSA option rom 
Dependencies:                               |   Patchstatus:  patch needs review   
--------------------------------------------+-------------------------------
Changes (by myles):

* patchstatus:  there is no patch => patch needs review

Comment:

you can't use "secure mode" with VSA, either

Signed-off-by: Myles Watson

#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA functions.

[Myles Watson]

Here's the patch for those that don't use the tracker.

you can't use "secure mode" with VSA, either

Signed-off-by: Myles Watson

Thanks,
Myles

#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA functions.

[Peter Stuge]

Myles Watson wrote:
> you can't use "secure mode" with VSA, either
>
> Signed-off-by: Myles Watson

Acked-by: Peter Stuge

#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA functions.

[Myles Watson]

On Fri, Jun 4, 2010 at 9:48 AM, Peter Stuge  wrote:
> Myles Watson wrote:
> > you can't use "secure mode" with VSA, either
> >
> > Signed-off-by: Myles Watson
>
> Acked-by: Peter Stuge

Rev 5608.

Thanks,
Myles

[coreboot]

#166: Compiling a Geode target without CONFIG_VGA_ROM_RUN fails to find VSA
functions.
-------------------------------------------+--------------------------------
   Reporter:  edwin_beasant@…              |          Owner:  stepan@…             
       Type:  defect                       |         Status:  closed               
   Priority:  major                        |      Milestone:  Going mainstream     
  Component:  coreboot                     |     Resolution:  fixed                
   Keywords:  Geode VSA option rom         |   Dependencies:                       
Patchstatus:  patch has been committed     |  
-------------------------------------------+--------------------------------
Changes (by myles):

* status:  new => closed
  * patchstatus:  patch needs review => patch has been committed
  * resolution:  => fixed