Re: [coreboot] [flashrom][PATCH] typo in Makefile

[Carl-Daniel Hailfinger]

On 24.04.2009 15:09, [e-mail] wrote:
> Selon Carl-Daniel Hailfinger :
> > On 24.04.2009 14:16, Ward Vandewege wrote:
> > > On Fri, Apr 24, 2009 at 11:15:07AM +0200, [e-mail] wrote:
> > > > > > Found some typo in Makefile which was producing some "strange
> >
> > behaviours"
> >
> > I originally insisted on >& because it worked on tcsh, but since make
> > uses /bin/sh and /bin/sh has to be POSIX compliant, we can use the POSIX
> > variant. >& is not POSIX compliant, but
> > > /dev/null 2>&1
> >
> > is POSIX compliant. This is specified in SuSv3, Shell command language,
> > sections 2.7.2 and 2.7.6.
> > > > > > Signed-off-by: Stephan Guilloux
> > >
> > > Acked-by: Ward Vandewege
> >
> > Stephan, would you mind resubmitting the 2>&1 variant? Thanks.
>
> Here it is and in attachment.
>
> Stephan.
>
> Signed-off-by: Stephan Guilloux

Signed-off-by: Carl-Daniel Hailfinger

Thanks, committed in r4211.

Regards,
Carl-Daniel