New patch to review for coreboot: c8071f3 haswell: remove GPIO60 memory reset gate on S3 transition

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2643

-gerrit

commit c8071f38775c4f5241f744b752b6dfc7be81f306
Author: Duncan Laurie 
Date:   Wed Dec 12 09:22:34 2012 -0800

haswell: remove GPIO60 memory reset gate on S3 transition

This is no longer tied to a GPIO but has a proper chipset pin.

Change-Id: Iba70338e8c67e3c3c1cb32e69bfea1282fda8cb5
    Signed-off-by: Duncan Laurie 
---
 src/southbridge/intel/lynxpoint/smihandler.c | 38 ----------------------------
 1 file changed, 38 deletions(-)

diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c
index d31e350..7c982d1 100644
--- a/src/southbridge/intel/lynxpoint/smihandler.c
+++ b/src/southbridge/intel/lynxpoint/smihandler.c
@@ -290,41 +290,6 @@ static void busmaster_disable_on_bus(int bus)
         }
 }

-/*
- * Drive GPIO 60 low to gate memory reset in S3.
- *
- * Intel reference designs all use GPIO 60 but it is
- * not a requirement and boards could use a different pin.
- */
-static void southbridge_gate_memory_reset(void)
-{
-	u32 reg32;
-	u16 gpiobase;
-
-	gpiobase = pci_read_config16(PCI_DEV(0, 0x1f, 0), GPIOBASE) & 0xfffc;
-	if (!gpiobase)
-		return;
-
-	/* Make sure it is set as GPIO */
-	reg32 = inl(gpiobase + GPIO_USE_SEL2);
-	if (!(reg32 & (1 << 28))) {
-		reg32 |= (1 << 28);
-		outl(reg32, gpiobase + GPIO_USE_SEL2);
-	}
-
-	/* Make sure it is set as output */
-	reg32 = inl(gpiobase + GP_IO_SEL2);
-	if (reg32 & (1 << 28)) {
-		reg32 &= ~(1 << 28);
-		outl(reg32, gpiobase + GP_IO_SEL2);
-	}
-
-	/* Drive the output low */
-	reg32 = inl(gpiobase + GP_LVL2);
-	reg32 &= ~(1 << 28);
-	outl(reg32, gpiobase + GP_LVL2);
-}
-
 static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *state_save)
 {
    u8 reg8;
@@ -372,9 +337,6 @@ static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *stat
    case 5:
    	printk(BIOS_DEBUG, "SMI#: Entering S3 (Suspend-To-RAM)\n");

-		/* Gate memory reset */
-		southbridge_gate_memory_reset();
-
    	/* Invalidate the cache before going to S3 */
    	wbinvd();
    	break;