cbfstool build issue in gcc 4.6.3

[The Gluglug]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

cbfs-mkstage.c: In function ‘is_phdr_ignored’:
cbfs-mkstage.c:45:84: error: cast to pointer from integer of different
size [-Werror=int-to-pointer-cast]

The fix was made in http://review.coreboot.org/#/c/7545/ but some
people were unhappy about the use of extra type casting.

One possible solution is to simply upgrade GCC, which I will, but I
would also like to get cbfstool to build again for this version of
GCC. The patch in the gerrit link works, but is not accepted for
upstream.

Does anyone know a better way of doing it?

Regards,
Francis Rowe.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJUbsexAAoJEP9Ft0z50c+UGU4H/3nXZpc3OlaLNg+Otfv16Xw1
Cu9lj59jqYZ4BKCWIl/ZFeZ2Dgpjgc2hJcYk+V5VcQwAWzAt/UquQJQLFBcR0gMd
eZycL6z3iJS9vGh3wqpT0y1xnOXk+CckrU+3wUpGcwYuVRw2PnTllrhBDirTFObJ
bOGuns8b8+wdRkuEc9kIyGgOqzSC2pLKNaPI9uYo2bAIz7J2O8IO0T6vLrfnYMqu
ytV1fArz/CViF685KDB4IXbqHKlKmnVLwRWZw5mEtic0TGrcKElrHry3KgnK3Z4z
eYgQ2SZ6AyA0fs7gjkC3JN9M7peWiKZ+q1DPugBnx8HBoDXIYs65QzDDFOE4yRw=
=caB/
-----END PGP SIGNATURE-----

[Scott Duplichan]

The Gluglug [mailto:[e-mail]] wrote:

]-----BEGIN PGP SIGNED MESSAGE-----
]Hash: SHA1
]
]Hi,
]
]cbfs-mkstage.c: In function ‘is_phdr_ignored’:
]cbfs-mkstage.c:45:84: error: cast to pointer from integer of different
]size [-Werror=int-to-pointer-cast]
]
]The fix was made in http://review.coreboot.org/#/c/7545/ but some
]people were unhappy about the use of extra type casting.
]
]One possible solution is to simply upgrade GCC, which I will, but I
]would also like to get cbfstool to build again for this version of
]GCC. The patch in the gerrit link works, but is not accepted for
]upstream.
]
]Does anyone know a better way of doing it?

What about: DEBUG("Ignoring program segment at %llx\n", ph_start);

Thanks,
Scott

]Regards,
]Francis Rowe.
]-----BEGIN PGP SIGNATURE-----
]Version: GnuPG v1.4.11 (GNU/Linux)
]
]iQEcBAEBAgAGBQJUbsexAAoJEP9Ft0z50c+UGU4H/3nXZpc3OlaLNg+Otfv16Xw1
]Cu9lj59jqYZ4BKCWIl/ZFeZ2Dgpjgc2hJcYk+V5VcQwAWzAt/UquQJQLFBcR0gMd
]eZycL6z3iJS9vGh3wqpT0y1xnOXk+CckrU+3wUpGcwYuVRw2PnTllrhBDirTFObJ
]bOGuns8b8+wdRkuEc9kIyGgOqzSC2pLKNaPI9uYo2bAIz7J2O8IO0T6vLrfnYMqu
]ytV1fArz/CViF685KDB4IXbqHKlKmnVLwRWZw5mEtic0TGrcKElrHry3KgnK3Z4z
]eYgQ2SZ6AyA0fs7gjkC3JN9M7peWiKZ+q1DPugBnx8HBoDXIYs65QzDDFOE4yRw=
]=caB/
]-----END PGP SIGNATURE-----

[The Gluglug]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

thanks. that worked. I'll update the gerrit and see what people think.

On 21/11/14 05:40, Scott Duplichan wrote:
> DEBUG("Ignoring program segment at %llx\n", ph_start);
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJUbtIxAAoJEP9Ft0z50c+UQAsH/jvJqJyHojxcafEeZSTzMs/K
i8HMt4CkFkIjkrSJ6hdB7oJWt7XfsLwywK6yLnUax5znAE+8jGF/drvl9BWzLGy2
Bubis2exv8KaGQqbkGb3/c+HzR9Epw44WZymDi5XFvtfka+IqGEkweLIZqhkg2i7
p7k9RtUg5J4TdlrjW29OGXUArDsxPig24rHqEYshOLlcjBiyqPOK0SxerXKf+uNE
hssQQMzmqRlHurXHIX+BgpLbV6ETI2mg5bT8KN0zX1TPm2ZzgrlyqJK5pXeUJ7cC
4hqEJ5tSHignD+YlPfqtOILAZ1LfUo1LZCcQUEdS7YZNYY7pTWwPDJ+hjtBhr88=
=sQCH
-----END PGP SIGNATURE-----

[Stefan Reinauer]

On 11/20/14 9:40 PM, Scott Duplichan wrote:
> The Gluglug [mailto:[e-mail]] wrote:
>
> ]-----BEGIN PGP SIGNED MESSAGE-----
> ]Hash: SHA1
> ]
> ]Hi,
> ]
> ]cbfs-mkstage.c: In function ‘is_phdr_ignored’:
> ]cbfs-mkstage.c:45:84: error: cast to pointer from integer of different
> ]size [-Werror=int-to-pointer-cast]
> ]
> ]The fix was made in http://review.coreboot.org/#/c/7545/ but some
> ]people were unhappy about the use of extra type casting.
> ]
> ]One possible solution is to simply upgrade GCC, which I will, but I
> ]would also like to get cbfstool to build again for this version of
> ]GCC. The patch in the gerrit link works, but is not accepted for
> ]upstream.
> ]
> ]Does anyone know a better way of doing it?
>
> What about: DEBUG("Ignoring program segment at %llx\n", ph_start);

That will break 64bit compilers for the sake of fixing 32bit compilers. 
Not the best either. I think the PRIx64 approach is better.
>

[Scott Duplichan]

Stefan Reinauer [mailto:[e-mail]] wrote:

]On 11/20/14 9:40 PM, Scott Duplichan wrote:
]> The Gluglug [mailto:[e-mail]] wrote:
]>
]> ]-----BEGIN PGP SIGNED MESSAGE-----
]> ]Hash: SHA1
]> ]
]> ]Hi,
]> ]
]> ]cbfs-mkstage.c: In function ‘is_phdr_ignored’:
]> ]cbfs-mkstage.c:45:84: error: cast to pointer from integer of different
]> ]size [-Werror=int-to-pointer-cast]
]> ]
]> ]The fix was made in http://review.coreboot.org/#/c/7545/ but some
]> ]people were unhappy about the use of extra type casting.
]> ]
]> ]One possible solution is to simply upgrade GCC, which I will, but I
]> ]would also like to get cbfstool to build again for this version of
]> ]GCC. The patch in the gerrit link works, but is not accepted for
]> ]upstream.
]> ]
]> ]Does anyone know a better way of doing it?
]>
]> What about: DEBUG("Ignoring program segment at %llx\n", ph_start);
]That will break 64bit compilers for the sake of fixing 32bit compilers. 
]Not the best either. I think the PRIx64 approach is better.

PRIx64 is certainly the most portable way. Too much uefi recently
is rotting my mind.

Thanks,
Scott

[Idwer Vollering]

2014-11-21 6:03 GMT+01:00 The Gluglug :
> One possible solution is to simply upgrade GCC, which I will, but I
> would also like to get cbfstool to build again for this version of
> GCC. The patch in the gerrit link works, but is not accepted for
> upstream.
>
> Does anyone know a better way of doing it?

Yes, we should use CC_x86_32 and co. from .xcompile instead. Can you
make that work?

Idwer