Re: [coreboot] [VERY IMPORTANT] Announcement regarding Apollo Lake Coreboot building

[Zoran Stojsavljevic]

You mean, this one (in *RED*)?

[user@localhost coreboot]$ cat .config | grep SPI
CONFIG_BOOT_DEVICE_SPI_FLASH_BUS=0
# CONFIG_TPM_ON_FAST_SPI is not set
# CONFIG_SPI_FLASH_INCLUDE_ALL_DRIVERS is not set
CONFIG_SOC_INTEL_COMMON_SPI_FLASH_PROTECT=y
# CONFIG_BOOTBLOCK_DEBUG_SPINLOOP is not set
# CONFIG_VERSTAGE_DEBUG_SPINLOOP is not set
# CONFIG_ROMSTAGE_DEBUG_SPINLOOP is not set
*CONFIG_SPI_FLASH=y*
CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP=y
CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY=y
# CONFIG_SPI_FLASH_SMM is not set
# CONFIG_SPI_FLASH_NO_FAST_READ is not set
# CONFIG_SPI_FLASH_FAST_READ_DUAL_OUTPUT_3B is not set
# CONFIG_SPI_FLASH_HAS_VOLATILE_GROUP is not set
# CONFIG_HAVE_SPI_CONSOLE_SUPPORT is not set
# CONFIG_BOOT_DEVICE_NOT_SPI_FLASH is not set
*CONFIG_BOOT_DEVICE_SPI_FLASH=y*
# CONFIG_HAVE_ROMSTAGE_CONSOLE_SPINLOCK is not set
# CONFIG_HAVE_ROMSTAGE_NVRAM_CBFS_SPINLOCK is not set
# CONFIG_HAVE_ROMSTAGE_MICROCODE_CBFS_SPINLOCK is not set
# CONFIG_DEBUG_SPI_FLASH is not set
[user@localhost coreboot]$
Which one (but, anyway, I think you are on the wrong mental tread, unless *you
explicitly prove to me that I am wrong*)? [image: Inline image 1]

Zoran

On Wed, Feb 22, 2017 at 3:39 PM, Aaron Durbin  wrote:
> On Wed, Feb 22, 2017 at 1:12 AM, Zoran Stojsavljevic
>  wrote:
> > Hello to community,
> >
> > I finally, after 3 days of additional very hard struggle, found out why I
> > have (while I am in the last stage of building CBFS) nonsense while
>
> building
> > APL-I Coreboot coreboot.rom?!
> >
> > Please, read carefully this announcement.
> >
> > For last three days I came to hard stop because of this failure:
> >
> > Just quick look into the final failure (all passed, but last stage - IFD
> > failed):
> > Compile IFDTOOL
> > HOSTCC     util/ifdfake/ifdfake
> > DD         Adding Intel Firmware Descriptor
> > IFDTOOL    Unlocking Management Engine
> >
> > File build/coreboot.pre is 8388608 bytes
> > No Flash Descriptor found in this image
> > src/southbridge/intel/common/firmware/Makefile.inc:50: recipe for target
> > 'add_intel_firmware' failed
> > make: *** [add_intel_firmware] Error 1
> > [user@localhost coreboot]$
> >
> > At first, I suspect that culprit my .config file, but I have checked it
> > several times (maybe > dozen), and I could NOT find any problem with it
> > (except minor doubts).
> >
> > Then I switched to inspect -southbridge- setup, but these is none, since
> > (simplified explanation/view) APL-I is SoC.
> >
> > The next phase was to inspect
> > src/southbridge/intel/common/firmware/Makefile.inc , but there
>
> (although my
> > make scripting is rusty) I could NOT find any problem...
> >
> > Finally, somewhere around 2:00 AM I noticed/determined the root cause of
>
> the
> > problem: the util/ifdtool/ifdtool.c, line:
> >           if (*(uint32_t *) (image + i) == 0x0FF0A55A) {
> >
> > YET another INTEL IOTG PED hidden road bomb: the latest APL-I FSP:
> > APL-I_FSP/ApolloLakeFspBinPkg/FspBin/ApolloLakeFsp.fd does NOT have
>
> pattern
> > 0x0FF0A55A embedded in it (I have checked with HxD WIN tool).
>
> So this device isn't supporting SPI boot? If so, then it's not
> surprise that there's no SPI descriptor. And you didn't add one it
> seems.
> > Then, modifying the C f-n static fdbar_t *find_fd(char *image, int size),
> > finally I've got success! :-(
> >
> > Hello Martin,
> >
> > Thank you for unselfish help.
> >
> > Best Regards,
> > Zoran Stojsavljevic