[PATCH] Drop unneeded header from i82371eb_enable_rom.c

[Keith Hui]

A "I am alive" ping kind of patch while I continue to figure out ACPI
for 440BX boards among other things.

Drops <stdint.h> from the file. My coreboot still compiles fine
without it. abuild tested.

Signed-off-by: Keith Hui

[Uwe Hermann]

On Fri, Oct 01, 2010 at 12:31:47AM -0400, Keith Hui wrote:
> A "I am alive" ping kind of patch while I continue to figure out ACPI
> for 440BX boards among other things.
>
> Drops <stdint.h> from the file. My coreboot still compiles fine
> without it. abuild tested.
>
> Signed-off-by: Keith Hui

Hm, not sure about this one. The file _does_ use stuff from stdint.h
directly, so technically having the #include is correct. On the other
hand, that .c file is included itself from romstage.c usually and
that file already #includes stdint.h (directly or indirectly itself).

Note that we're currently trying to move away from including .c files
directly, as soon as that is done and the files are compiled separately
the #include may very well be required then (well, I think).

Uwe.

RFC: Typed -- was Re: [PATCH] Drop unneeded header from i82371eb_enable_rom.c

[Stefan Reinauer]

On 10/2/10 2:43 PM, Uwe Hermann wrote:
> Hm, not sure about this one. The file _does_ use stuff from stdint.h

What's the general feeling about types... Should we get rid of the
stdint.h usage and go for u8/u16/u32/s8/s16/s32 completely?

Stefan

RFC: Typed -- was Re: [PATCH] Drop unneeded header from i82371eb_enable_rom.c

[Uwe Hermann]

On Sat, Oct 02, 2010 at 05:34:58PM +0200, Stefan Reinauer wrote:
> On 10/2/10 2:43 PM, Uwe Hermann wrote:
> > Hm, not sure about this one. The file _does_ use stuff from stdint.h
>
> What's the general feeling about types... Should we get rid of the
> stdint.h usage and go for u8/u16/u32/s8/s16/s32 completely?

Definately, long-term we should use u8 etc. in the whole code base.

However, currently u8 and friends are also defined in our stdint.h so
that's a different issue (or we move the u8 defines).

Uwe.

RFC: Typed -- was Re: [PATCH] Drop unneeded header from i82371eb_enable_rom.c

[ron minnich]

On Sat, Oct 2, 2010 at 8:34 AM, Stefan Reinauer
 wrote:
> On 10/2/10 2:43 PM, Uwe Hermann wrote:
> > Hm, not sure about this one. The file _does_ use stuff from stdint.h
>
> What's the general feeling about types... Should we get rid of the
> stdint.h usage and go for u8/u16/u32/s8/s16/s32 completely?

I always felt we should get rid of stdint.h and define our own. Using
stdint.h leaves you hostage to whatever the gcc guys may do with that
file in the future.

ron

RFC: Typed -- was Re: [PATCH] Drop unneeded header from i82371eb_enable_rom.c

[Peter Stuge]

Stefan Reinauer wrote:
> What's the general feeling about types... Should we get rid of the
> stdint.h usage and go for u8/u16/u32/s8/s16/s32 completely?

I like the short ones too.

//Peter

RFC: Typed -- was Re: [PATCH] Drop unneeded header from i82371eb_enable_rom.c

[Carl-Daniel Hailfinger]

On 02.10.2010 21:06, Peter Stuge wrote:
> Stefan Reinauer wrote:
> > What's the general feeling about types... Should we get rid of the
> > stdint.h usage and go for u8/u16/u32/s8/s16/s32 completely?
>
> I like the short ones too.

+1

Regards,
Carl-Daniel