Patrick Georgi wrote:
Am 01.10.2010 01:33, schrieb Peter Stuge:
would it work to simply make these options be NORTHBRIDGE_INTEL_I945GC and _I945GM
..
Thought about it - why I didn't do that: It significantly changes the design of that part of the code. The change above simply moves stuff around.
Patrick Georgi wrote:
Acked-by: Peter Stuge peter@stuge.se
Thanks, r5891
The help texts are cleaned up, and the chipset variant setting isn't user visible anymore (I think - tested in "make config" only)
Attached is the patch to remove the separate variant setting and put the info in the NORTHBRIDGE_ option.
Build tested on Getac (GM) and d945gclf (GC).
//Peter
Am 01.10.2010 11:02, schrieb Peter Stuge:
Split NORTHBRIDGE_INTEL_I945 into more precise _I945GC and _I945GM
Both chipsets use the src/northbridge/intel/i945 code but that code needs to know which chipset is actually used. Having separate NORTHBRIDGE_ options allows the I945GC/I945GM choice to be removed since code can test the NORTHBRIDGE_ option directly.
Signed-off-by: Peter Stuge peter@stuge.se
Acked-by: Patrick Georgi patrick.georgi@coresystems.de and committed in r5893
Also fixes my stupid compile breakage in r5891
Thanks, Patrick