Modify it based on the RPR. 5.7.7. Switching GPPSB Configuration By Register Programming.
Signed-off-by: Zheng Bao zheng.bao@amd.com
Index: src/southbridge/amd/rs690/rs690_pcie.c =================================================================== --- src/southbridge/amd/rs690/rs690_pcie.c (revision 469) +++ src/southbridge/amd/rs690/rs690_pcie.c (working copy) @@ -148,7 +148,7 @@ /* waits until SB has trained to L0, poll for bit0-5 = 0x10 */ do { reg = nbpcie_p_read_index(sb_dev, PCIE_LC_STATE0); - reg &= 0x1f; /* remain LSB 5 bits */ + reg &= 0x3f; /* remain LSB [5:0] bits */ } while (LC_STATE_RECONFIG_GPPSB != reg);
/* ensures that virtual channel negotiation is completed. poll for bit1 = 0 */
On 01.06.2009 04:34, Bao, Zheng wrote:
Modify it based on the RPR. 5.7.7. Switching GPPSB Configuration By Register Programming.
Signed-off-by: Zheng Bao zheng.bao@amd.com
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Do you have commit rights or should I commit?
Regards, Carl-Daniel
I don't have commit right. I don't know the exact process to apply it. It would be better if I can get the commit right to the amd/rs690 and amd/sb600.
Zheng
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Carl-Daniel Hailfinger Sent: Tuesday, June 02, 2009 8:31 AM To: Bao, Zheng Cc: coreboot Subject: Re: [coreboot] [patch]: a little error is fixed.
On 01.06.2009 04:34, Bao, Zheng wrote:
Modify it based on the RPR. 5.7.7. Switching GPPSB Configuration By Register Programming.
Signed-off-by: Zheng Bao zheng.bao@amd.com
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Do you have commit rights or should I commit?
Regards, Carl-Daniel
Hi Zheng,
On 02.06.2009 03:52, Bao, Zheng wrote:
I don't have commit right. I don't know the exact process to apply it. It would be better if I can get the commit right to the amd/rs690 and amd/sb600.
Commit rights are for the whole tree and are given to people who will work on the tree a lot in the future. I hope you can submit and commit the 780/SB700 code soon.
Stefan manages commit rights. I have added him to this mail.
Regards, Carl-Daniel
Thanks, committed in r4331.
Zheng
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Carl-Daniel Hailfinger Sent: Tuesday, June 02, 2009 8:31 AM To: Bao, Zheng Cc: coreboot Subject: Re: [coreboot] [patch]: a little error is fixed.
On 01.06.2009 04:34, Bao, Zheng wrote:
Modify it based on the RPR. 5.7.7. Switching GPPSB Configuration By Register Programming.
Signed-off-by: Zheng Bao zheng.bao@amd.com
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Do you have commit rights or should I commit?
Regards, Carl-Daniel