[PATCH] v2: Enable CBFS and HIGH_TABLES for MSI MS-6178

[Uwe Hermann]

See patch.

The trouble I was having earlier with CBFS seems to come from removing
the "normal" image (to get more space in the ROM). I'll investigate.
The attached patch works fine though.

Uwe.

[PATCH] v2: Enable CBFS and HIGH_TABLES for MSI MS-6178

[Myles Watson]

> The trouble I was having earlier with CBFS seems to come from removing
> the "normal" image (to get more space in the ROM).

Strange.  I thought that was fixed.
> The attached patch works fine though.

The HIGH_TABLES failed with:

No matching ram area found for range:
    [0x00000000000f0000, 0x0000000000100000)
  Ram areas
    [0x0000000000000000, 0x0000000000001000) Reserved
    [0x0000000000001000, 0x00000000000a0000) RAM
    [0x0000000000100000, 0x000000000fff0000) RAM
    [0x000000000fff0000, 0x0000000010000000) Reserved
  SELFBOOT RETURNED!
  Boot failed.

This looks like a separate issue from HIGH_TABLES support.  It looks like
the payload wasn't finding RAM to live in.  Did you try SeaBIOS as a payload
without HIGH_TABLES support?

===================================================================
--- src/northbridge/intel/i82810/northbridge.c	(Revision 4363)
+++ src/northbridge/intel/i82810/northbridge.c	(Arbeitskopie)
@@ -170,7 +170,7 @@
    	/* Report the memory regions. */
    	idx = 10;
    	ram_resource(dev, idx++, 0, 640);
-		ram_resource(dev, idx++, 1024, tolmk - 1024);
+		ram_resource(dev, idx++, 768, tolmk - 768);

I think it would be nice if there were some easy way to see that 768K =
0xC0000 here, but I'm not sure of the best way to express that.  Maybe just
a comment.

Acked-by: Myles Watson

Thanks,
Myles

[PATCH] v2: Enable CBFS and HIGH_TABLES for MSI MS-6178

[Patrick Georgi]

Myles Watson schrieb:
> > The trouble I was having earlier with CBFS seems to come from removing
> > the "normal" image (to get more space in the ROM).
>
> Strange.  I thought that was fixed.

That was a different issue: Trying to use normal in a CBFS configuration 
(which didn't work due to improper offsets).

Patrick

[PATCH] v2: Enable CBFS and HIGH_TABLES for MSI MS-6178

[Uwe Hermann]

On Fri, Jun 19, 2009 at 06:49:47AM -0600, Myles Watson wrote:
> > The trouble I was having earlier with CBFS seems to come from removing
> > the "normal" image (to get more space in the ROM).
>
> Strange.  I thought that was fixed.
> > The attached patch works fine though.
>
> The HIGH_TABLES failed with:
>
> No matching ram area found for range:
>     [0x00000000000f0000, 0x0000000000100000)
>   Ram areas
>     [0x0000000000000000, 0x0000000000001000) Reserved
>     [0x0000000000001000, 0x00000000000a0000) RAM
>     [0x0000000000100000, 0x000000000fff0000) RAM
>     [0x000000000fff0000, 0x0000000010000000) Reserved
>   SELFBOOT RETURNED!
>   Boot failed.
>
> This looks like a separate issue from HIGH_TABLES support.  It looks like
> the payload wasn't finding RAM to live in.  Did you try SeaBIOS as a payload
> without HIGH_TABLES support?

Will investigate. I do know that it worked before enabling HIGH_TABLES,
but not afterwards. But I'll recheck to be sure.

Committed in r4365.

Uwe.

[PATCH] v2: Enable CBFS and HIGH_TABLES for MSI MS-6178

[Patrick Georgi]

Uwe Hermann schrieb:
> See patch.
>
> The trouble I was having earlier with CBFS seems to come from removing
> the "normal" image (to get more space in the ROM). I'll investigate.
> The attached patch works fine though.

except the HIGH_TABLES stuff (and its workaround),

Acked-by: Patrick Georgi

For the HIGH_TABLES issue, there might be other, cleaner options (as 
discussed on IRC), like using tomk (or tomlk some lines later, at least 
the same at both places).

Patrick