Re: [coreboot] [v2] r4191 - trunk/coreboot-v2/src/config

[Stephan Raue]

Am 23.04.2009 01:27, schrieb [e-mail]:
> Author: hailfinger
> Date: 2009-04-23 01:27:25 +0200 (Thu, 23 Apr 2009)
> New Revision: 4191
>
> Modified:
>     trunk/coreboot-v2/src/config/Options.lb
> Log:
> Sometimes when we debug the code, we need to know which version we are
> working on.
> Add the svn revision to the coreboot version string.
>
> Signed-off-by: Zheng Bao
> Acked-by: Myles Watson
> Acked-by: Carl-Daniel Hailfinger
> Modified: trunk/coreboot-v2/src/config/Options.lb
>
> --- trunk/coreboot-v2/src/config/Options.lb	2009-04-22 23:17:44 UTC (rev 4190)
> +++ trunk/coreboot-v2/src/config/Options.lb	2009-04-22 23:27:25 UTC (rev 4191)
> @@ -97,7 +97,7 @@
>    comment "Objcopy command"
>   end
>   define COREBOOT_VERSION
> default "2.0.0"
> default "2.0.0-r$(shell if [ -f `which svnversion` ]; then svnversion $(TOP); fi)"

how i can handle this, when i am provide a source-package downloaded 
with a very recent svn-program and packaged this to *tar.bz2.

when this tar.bz2 is downloaded by any person that have a older svn 
program he has an error like this:

http://subversion.tigris.org/faq.html#working-copy-format-change

this is also a "problem" with flashrom

Stephan

[v2] r4191 - trunk/coreboot-v2/src/config

[Carl-Daniel Hailfinger]

On 23.04.2009 01:51, Stephan Raue wrote:
> Am 23.04.2009 01:27, schrieb [e-mail]:
> > Author: hailfinger
> > Date: 2009-04-23 01:27:25 +0200 (Thu, 23 Apr 2009)
> > New Revision: 4191
> >
> > Modified:
> >     trunk/coreboot-v2/src/config/Options.lb
> > Log:
> > Sometimes when we debug the code, we need to know which version we are
> > working on.
> > Add the svn revision to the coreboot version string.
> >
> > Signed-off-by: Zheng Bao
> > Acked-by: Myles Watson
> > Acked-by: Carl-Daniel Hailfinger
> > Modified: trunk/coreboot-v2/src/config/Options.lb
> >
> > --- trunk/coreboot-v2/src/config/Options.lb    2009-04-22 23:17:44
> > UTC (rev 4190)
> > +++ trunk/coreboot-v2/src/config/Options.lb    2009-04-22 23:27:25
> > UTC (rev 4191)
> > @@ -97,7 +97,7 @@
> >       comment "Objcopy command"
> >   end
> >   define COREBOOT_VERSION
> > default "2.0.0"
> > default "2.0.0-r$(shell if [ -f `which svnversion` ]; then
> >
> > svnversion $(TOP); fi)"
>
> how i can handle this, when i am provide a source-package downloaded
> with a very recent svn-program and packaged this to *tar.bz2.

Does the tarball really contain a .svn directory?
> when this tar.bz2 is downloaded by any person that have a older svn
> program he has an error like this:
>
> http://subversion.tigris.org/faq.html#working-copy-format-change
>
> this is also a "problem" with flashrom

A fix for git mirrors and more is in the works.

Regards,
Carl-Daniel

[v2] r4191 - trunk/coreboot-v2/src/config

[Stephan Raue]

Am 23.04.2009 01:58, schrieb Carl-Daniel Hailfinger:
> On 23.04.2009 01:51, Stephan Raue wrote:
> > Am 23.04.2009 01:27, schrieb [e-mail]:
> > > Author: hailfinger
> > > Date: 2009-04-23 01:27:25 +0200 (Thu, 23 Apr 2009)
> > > New Revision: 4191
> > >
> > > Modified:
> > >      trunk/coreboot-v2/src/config/Options.lb
> > > Log:
> > > Sometimes when we debug the code, we need to know which version we are
> > > working on.
> > > Add the svn revision to the coreboot version string.
> > >
> > > Signed-off-by: Zheng Bao
> > > Acked-by: Myles Watson
> > > Acked-by: Carl-Daniel Hailfinger
> > > Modified: trunk/coreboot-v2/src/config/Options.lb
> > >
> > > --- trunk/coreboot-v2/src/config/Options.lb    2009-04-22 23:17:44
> > > UTC (rev 4190)
> > > +++ trunk/coreboot-v2/src/config/Options.lb    2009-04-22 23:27:25
> > > UTC (rev 4191)
> > > @@ -97,7 +97,7 @@
> > >        comment "Objcopy command"
> > >    end
> > >    define COREBOOT_VERSION
> > > default "2.0.0"
> > > default "2.0.0-r$(shell if [ -f `which svnversion` ]; then
> > >
> > > svnversion $(TOP); fi)"
> >
> > how i can handle this, when i am provide a source-package downloaded
> > with a very recent svn-program and packaged this to *tar.bz2.
>
> Does the tarball really contain a .svn directory?

yes the tarball contain a .svn directory and i can change or remove this 
calls - i dont know if its a problem for flashrom when the svnversion is 
incorrect on compiling time.

[v2] r4191 - trunk/coreboot-v2/src/config

[Peter Stuge]

Stephan Raue wrote:
> yes the tarball contain a .svn directory and i can change or remove
> this calls -

I certainly would if I was redistributing coreboot source.
> i dont know if its a problem for flashrom when the svnversion is
> incorrect on compiling time.

You have to do the same thing there. Manually replace the calls with
the revision number that you downloaded.

If you make some local changes and have not yet pushed them back to
us, we ask that you add some identifier of your own to the version
number.

//Peter

[v2] r4191 - trunk/coreboot-v2/src/config

[Peter Stuge]

Stephan Raue wrote:
> > default "2.0.0-r$(shell if [ -f `which svnversion` ]; then svnversion $(TOP); fi)"
>
> how i can handle this, when i am provide a source-package downloaded
> with a very recent svn-program and packaged this to *tar.bz2.

I would replace all svn calls before creating the package. That would
add value for the customers.

//Peter