Stefan Reinauer wrote:
- Carl-Daniel Hailfinger wrote:
What we need from you is a way to use nrv2b compressed ELF images as payload. Please don't say that is impossible.
CONFIG_COMPRESSED_ROM_STREAM does exactly that.
You need to give it an uncompressed payload since it does compression on its own.
ARGH! Now that indeed explains things very well.
Attached is a patch to make LinuxBIOS support precompressed payloads. While the LinuxBIOS build system can compress payloads on its own, the OLPC build system benefits from delivering a precompressed (and size-checked) payload.
Although the patch modifies targets/olpc/rev_a/Config.1M.lb this has no effect on current OLPC buildrom because it checks out an earlier revision of LinuxBIOS. So it should be a safe to apply.
As a reply to this message, I'll post the necessary OLPC buildrom changes to make use of the new infrastructure.
Regards, Carl-Daniel
Carl-Daniel Hailfinger wrote:
Stefan Reinauer wrote:
- Carl-Daniel Hailfinger wrote:
What we need from you is a way to use nrv2b compressed ELF images as payload. Please don't say that is impossible.
CONFIG_COMPRESSED_ROM_STREAM does exactly that.
You need to give it an uncompressed payload since it does compression on its own.
ARGH! Now that indeed explains things very well.
Attached is a patch to make LinuxBIOS support precompressed payloads.
Although the patch modifies targets/olpc/rev_a/Config.1M.lb this has no effect on current OLPC buildrom because it checks out an earlier revision of LinuxBIOS. So it should be a safe to apply.
And here is the patch to buildrom to make use of the new infrastructure. Please note that it should only be applied AFTER the LinuxBIOS patch in my last mail has been merged upstream. You may have to change the checked out revision in packages/linuxbios/linuxbios.mk.
Regards, Carl-Daniel
Carl-Daniel U. Hailfinger wrote:
And here is the patch to buildrom to make use of the new infrastructure. Please note that it should only be applied AFTER the LinuxBIOS patch in my last mail has been merged upstream. You may have to change the checked out revision in packages/linuxbios/linuxbios.mk.
as soon as someone tests that new version of linuxbios and it works, we can do that change.
Thanks, this is excellent work.
ron
stefan, if this patch is ok with you, it's ok with me too.
thanks
ron
* Ronald G Minnich rminnich@lanl.gov [060803 17:27]:
stefan, if this patch is ok with you, it's ok with me too.
The CONFIG_PRECOMPRESSED_ROM_STREAM patch is fine. No curlicues but ok to commit. A cleaner version would be to autodetect if the nrv2b stream is already compressed. But: - nrv2b would need to be extended - we have lzma in mind anyways - the patch is simple
Stefan
* Stefan Reinauer stepan@coresystems.de [060803 18:09]:
- Ronald G Minnich rminnich@lanl.gov [060803 17:27]:
stefan, if this patch is ok with you, it's ok with me too.
The CONFIG_PRECOMPRESSED_ROM_STREAM patch is fine. No curlicues but ok to commit. A cleaner version would be to autodetect if the nrv2b stream is already compressed. But:
- nrv2b would need to be extended
- we have lzma in mind anyways
- the patch is simple
Applied.
Stefan Reinauer wrote:
- Stefan Reinauer stepan@coresystems.de [060803 18:09]:
- Ronald G Minnich rminnich@lanl.gov [060803 17:27]:
stefan, if this patch is ok with you, it's ok with me too.
The CONFIG_PRECOMPRESSED_ROM_STREAM patch is fine. No curlicues but ok to commit. A cleaner version would be to autodetect if the nrv2b stream is already compressed. But:
- nrv2b would need to be extended
- we have lzma in mind anyways
- the patch is simple
Applied.
Thanks!
Regards, Carl-Daniel
On 03/08/06 08:24 +0200, Carl-Daniel U. Hailfinger wrote:
Stefan Reinauer wrote:
- Carl-Daniel Hailfinger wrote:
What we need from you is a way to use nrv2b compressed ELF images as payload. Please don't say that is impossible.
CONFIG_COMPRESSED_ROM_STREAM does exactly that.
You need to give it an uncompressed payload since it does compression on its own.
ARGH! Now that indeed explains things very well.
Attached is a patch to make LinuxBIOS support precompressed payloads. While the LinuxBIOS build system can compress payloads on its own, the OLPC build system benefits from delivering a precompressed (and size-checked) payload.
Although the patch modifies targets/olpc/rev_a/Config.1M.lb this has no effect on current OLPC buildrom because it checks out an earlier revision of LinuxBIOS. So it should be a safe to apply.
Ron - you'll have to decide if you want to apply this to LinuxBIO or not - and then we'll just use the new revision.
This scares me - I don't like that we can't easily control the behavior here without patches (that would have to be updated every time we change revisions).
Jordan
Jordan Crouse wrote:
Ron - you'll have to decide if you want to apply this to LinuxBIO or not - and then we'll just use the new revision.
There's no problem applying these patches.
I go with a fixed rev of linuxbios for OLPC because I want to avoid the 'broken tip of tree' experience. Every once in a while somebody busts a linuxbios build for a given platform due to things you can't always foresee. So, by using a fixed version of linuxbios, we can ensure that anyone who uses buildrom is guaranteed to get a working flash image.
This scares me - I don't like that we can't easily control the behavior here without patches (that would have to be updated every time we change revisions).
I think I'm not sure what you mean. Our goal should be to have a known-good, patch-free svn rev of linuxbios to use for buildrom.
I don't like local patches.
ron
-
Carl-Daniel U. Hailfinger -
Jordan Crouse -
Ronald G Minnich -
Stefan Reinauer