Hi,
here's the remainders of Yinghai's MCP55 patch. Let's get this reviewed and committed ASAP so we can announce yet another bunch of supported mainboards :)
I tried to clean up some parts of the code which are the results of the diff being made against a pretty old code base, but not all is yet cleaned (yh_rest_of_patch.patch needs more work).
The yh_mainboards_targets.patch consists of all-new code, so it can be safely committed, except for two issues:
* License headers are mostly missing.
* I don't know whether the code will actually build or work without the changes in yh_rest_of_patch.patch (probably not).
HTH, Uwe.
Hi,
Uwe Hermann wrote:
here's the remainders of Yinghai's MCP55 patch. Let's get this reviewed and committed ASAP so we can announce yet another bunch of supported mainboards :)
The yh_mainboards_targets.patch consists of all-new code, so it can be safely committed, except for two issues:
License headers are mostly missing.
I don't know whether the code will actually build or work without the changes in yh_rest_of_patch.patch (probably not).
* Tabs vs. spaces * Missing end-of-lines
-- targets/supermicro/h8dmr/Config.lb (Revision 0) +++ targets/supermicro/h8dmr/Config.lb (Revision 0) @@ -0,0 +1 @@ +link Config.lb.payload \ Kein Zeilenvorschub am Ende der Datei
Eigenschaftsänderungen: targets/supermicro/h8dmr/Config.lb ___________________________________________________________________ Name: svn:special
--- targets/gigabyte/m57sli/Config.lb (Revision 0) +++ targets/gigabyte/m57sli/Config.lb (Revision 0) @@ -0,0 +1 @@ +link Config.lb.payload \ Kein Zeilenvorschub am Ende der Datei
Eigenschaftsänderungen: targets/gigabyte/m57sli/Config.lb ___________________________________________________________________ Name: svn:special
--- targets/tyan/s2912/Config.lb (Revision 0) +++ targets/tyan/s2912/Config.lb (Revision 0) @@ -0,0 +1 @@ +link Config.lb.payload \ Kein Zeilenvorschub am Ende der Datei
Eigenschaftsänderungen: targets/tyan/s2912/Config.lb ___________________________________________________________________ Name: svn:special
Index: targets/payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf
Kann nicht anzeigen: Dateityp ist als binär angegeben. svn:mime-type = application/octet-stream
Eigenschaftsänderungen: targets/payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf ___________________________________________________________________ Name: svn:executable
Name: svn:mime-type
- application/octet-stream
--- targets/nvidia/l1_2pvv/Config.lb (Revision 0) +++ targets/nvidia/l1_2pvv/Config.lb (Revision 0) @@ -0,0 +1 @@ +link Config.lb.payload \ Kein Zeilenvorschub am Ende der Datei
Eigenschaftsänderungen: targets/nvidia/l1_2pvv/Config.lb ___________________________________________________________________ Name: svn:special
Do we have the right to distribute the PIR tables of the original BIOS?
--- src/mainboard/supermicro/h8dmr/irq_tables.c (Revision 0) +++ src/mainboard/supermicro/h8dmr/irq_tables.c (Revision 0) @@ -0,0 +1,96 @@ +/* This file was generated by getpir.c, do not modify!
- (but if you do, please run checkpir on it to verify)
- Contains the IRQ Routing Table dumped directly from your memory , wich BIOS sets up
Regards, Carl-Daniel
Hi,
On Tue, Feb 13, 2007 at 04:43:19PM +0100, Carl-Daniel Hailfinger wrote:
- Tabs vs. spaces
- Missing end-of-lines
Yes, but I don't consider these blockers. We can commit nevertheless, and then fix these later with an extra patch.
-- targets/supermicro/h8dmr/Config.lb (Revision 0) +++ targets/supermicro/h8dmr/Config.lb (Revision 0) @@ -0,0 +1 @@ +link Config.lb.payload \ Kein Zeilenvorschub am Ende der Datei
Eigenschaftsänderungen: targets/supermicro/h8dmr/Config.lb ___________________________________________________________________ Name: svn:special
These are just indicators that there's a symlink Config.lb -> Config.lb.payload, if I'm not mistaken.
How should we handle this in the repository?
Do we have the right to distribute the PIR tables of the original BIOS?
--- src/mainboard/supermicro/h8dmr/irq_tables.c (Revision 0) +++ src/mainboard/supermicro/h8dmr/irq_tables.c (Revision 0) @@ -0,0 +1,96 @@ +/* This file was generated by getpir.c, do not modify!
- (but if you do, please run checkpir on it to verify)
- Contains the IRQ Routing Table dumped directly from your memory , wich BIOS sets up
I have no idea, but we already distribute multiple of those getpir.c-outputs in our current code base, I think, so it's probably ok. Anybody who knows more?
Uwe.
- I don't know whether the code will actually build or work without the changes in yh_rest_of_patch.patch (probably not).
It should rename ROM_STREAM to ROM_PAYLOAD in Config.lb and Options.lb of mainboard directory , otherwise it can't compile.
bxshi
On 2/13/07, bxshi bingxunshi@gmail.com wrote:
It should rename ROM_STREAM to ROM_PAYLOAD in Config.lb and Options.lb of mainboard directory , otherwise it can't compile.
Here are the patches Uwe sent, with the following changes:
- changed STREAM options to PAYLOAD as necessary - removed parts that would have undone STREAM -> PAYLOAD change - removed a binary file (targets/payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf)
I haven't done an abuild yet, but more changes are likely necessary.
--Ed
Hi,
On Thu, Feb 15, 2007 at 10:14:00AM -0800, Ed Swierk wrote:
Here are the patches Uwe sent, with the following changes:
- changed STREAM options to PAYLOAD as necessary
- removed parts that would have undone STREAM -> PAYLOAD change
- removed a binary file
(targets/payloads/forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf)
Thanks a lot, but please resend the patch with your sign-off.
As for forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf -- do we need that, do we have source code for it? Or is it just some test-payload which we can safely ignore?
Uwe.
can somebody get this committed now? The vendor is getting anxious :-)
thanks!
ron
On 2/15/07, Uwe Hermann uwe@hermann-uwe.de wrote:
Thanks a lot, but please resend the patch with your sign-off.
OK, but as I said, the patches haven't received any testing, so I'm not asserting that they work.
Signed-off-by: Ed Swierk eswierk@arastra.com
As for forcedeth--filo_hda2_vga_5_4_2_mcp55.zelf -- do we need that, do we have source code for it? Or is it just some test-payload which we can safely ignore?
I'm assuming that it's just a FILO image with the forcedeth driver from the Etherboot codebase, but only Yinghai would know for sure.
--Ed
On 2/15/07, Ed Swierk eswierk@arastra.com wrote:
OK, but as I said, the patches haven't received any testing, so I'm not asserting that they work.
I should add that the patch may well break mainboards that are currently working, so caveat emptor.
On the other hand, it will certainly be easier for us to collaborate on fixing things once the code is committed.
--Ed
New version of the src/mainboard/ and targets/ contents, with license headers added.
This can be committed IHMO. It won't build, but it shouldn't break anything either. So:
Acked-by: Uwe Hermann uwe@hermann-uwe.de
I'm waiting for one more Ack before I commit.
Uwe.
On 2/16/07, Uwe Hermann uwe@hermann-uwe.de wrote:
New version of the src/mainboard/ and targets/ contents, with license headers added.
This can be committed IHMO. It won't build, but it shouldn't break anything either. So:
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Ronald G. Minnich rminnich@gmail.com
Please close this thread out witha commit message and version #. This is a great patch -- 4 new mainboards. Thanks all!
Probably be a good idea to put this news on the wiki too. That's five new mainboards this month!
Of course, we have to get them to build now :-) -- uwe, what's missing at this point? This is a huge set of changes.
We should never forget the vendors here. Supermicro, MSI, Nvidia, Gigabyte, Tyan -- all of them letting this work go forward. And, of course, AMD, who support the LinuxBIOS project in such fine form by supporingt Dr. Lu. Let's be glad we have great companies like this to work with!
Now, go forth and buy their products :-)
ron
On Fri, Feb 16, 2007 at 08:44:54AM -0700, ron minnich wrote:
Of course, we have to get them to build now :-) -- uwe, what's missing at this point? This is a huge set of changes.
We should never forget the vendors here. Supermicro, MSI, Nvidia, Gigabyte, Tyan -- all of them letting this work go forward. And, of course, AMD, who support the LinuxBIOS project in such fine form by supporingt Dr. Lu. Let's be glad we have great companies like this to work with!
Now, go forth and buy their products :-)
We've just purchased 2 of the Gigabyte boards; they should arrive sometime next week. I'm going to be trying to build LB for them, and I'll be sure to report here. If that goes well, we're going to buy another 5 boards (we're upgrading desktop machines).
Thanks, Ward.
Hi,
On Fri, Feb 16, 2007 at 08:44:54AM -0700, ron minnich wrote:
Please close this thread out witha commit message and version #. This is a great patch -- 4 new mainboards. Thanks all!
Committed in rev. 2554.
Probably be a good idea to put this news on the wiki too. That's five new mainboards this month!
Yes, but not yet, there are still two patches missing. The mainboards won't build, yet.
We should never forget the vendors here. Supermicro, MSI, Nvidia, Gigabyte, Tyan -- all of them letting this work go forward. And, of course, AMD, who support the LinuxBIOS project in such fine form by supporingt Dr. Lu. Let's be glad we have great companies like this to work with!
Indeed, thanks a lot to all involved vendors and of course Yinghai for the great work!
Uwe.
Hi Uwe and list,
On Sat, Feb 17, 2007 at 03:31:42PM +0100, Uwe Hermann wrote:
Probably be a good idea to put this news on the wiki too. That's five new mainboards this month!
Yes, but not yet, there are still two patches missing. The mainboards won't build, yet.
So, what's the status on these patches? A couple of the Gigabyte boards arrived here yesterday, and I'd like to try them out :)
What is somewhat disappointing is that the Gigabyte GA-M57SLI-S4 that we got has the bios chip soldered on. Guess there's some plcc soldering to be done...
Thanks, Ward.
-
bxshi -
Carl-Daniel Hailfinger -
Ed Swierk -
ron minnich -
Uwe Hermann -
Ward Vandewege