New Defects reported by Coverity Scan for coreboot

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

3 new defect(s) introduced to coreboot found with Coverity Scan.
175 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)

** CID 1430454:  Null pointer dereferences  (NULL_RETURNS)

________________________________________________________________________________________________________
*** CID 1430454:  Null pointer dereferences  (NULL_RETURNS)
/src/drivers/usb/pci_xhci/pci_xhci.c: 193 in xhci_fill_ssdt()
187     static void xhci_fill_ssdt(const struct device *dev)
188     {
189     	int gpe;
190     
191     	printk(BIOS_DEBUG, "xHCI SSDT generation\n");
192
> > > CID 1430454:  Null pointer dereferences  (NULL_RETURNS)
> > > Dereferencing a pointer that might be "NULL" "acpi_device_scope(dev)" when calling "acpigen_write_scope".

193     	acpigen_write_scope(acpi_device_scope(dev));
194     	acpigen_write_device(acpi_device_name(dev));
195     
196     	acpigen_write_ADR_pci_device(dev);
197     	acpigen_write_name_string("_DDN", "xHC - Extensible Host Controller");
198     	acpigen_write_STA(acpi_device_status(dev));

** CID 1430218:  Integer handling issues  (BAD_SHIFT)
/src/ec/google/chromeec/ec.c: 397 in google_chromeec_log_events()

________________________________________________________________________________________________________
*** CID 1430218:  Integer handling issues  (BAD_SHIFT)
/src/ec/google/chromeec/ec.c: 397 in google_chromeec_log_events()
391     
392     	if (!CONFIG(ELOG))
393     		return;
394     
395     	events = google_chromeec_get_events_b() & mask;
396     	for (i = 0; i < sizeof(events) * 8; i++) {
> > > CID 1430218:  Integer handling issues  (BAD_SHIFT)
> > > In expression "1ULL << i - 1", shifting by a negative amount has undefined behavior.  The shift amount, "i - 1", is -1.

397     		if (EC_HOST_EVENT_MASK(i) & events)
398     			elog_add_event_byte(ELOG_TYPE_EC_EVENT, i);
399     	}
400     
401     	google_chromeec_clear_events_b(events);
402     }

** CID 1429776:  Memory - corruptions  (OVERRUN)

________________________________________________________________________________________________________
*** CID 1429776:  Memory - corruptions  (OVERRUN)
/src/soc/amd/picasso/fsp_params.c: 94 in fsp_fill_pcie_ddi_descriptors()
88     	const fsp_ddi_descriptor *fsp_ddi;
89     	size_t num_pcie;
90     	size_t num_ddi;
91     
92     	mainboard_get_pcie_ddi_descriptors(&fsp_pcie, &num_pcie,
93     						&fsp_ddi, &num_ddi);
> > > CID 1429776:  Memory - corruptions  (OVERRUN)
> > > Overrunning callee's array of size 1 by passing argument "num_pcie" (which evaluates to 3) in call to "fill_pcie_descriptors".

94     	fill_pcie_descriptors(scfg, fsp_pcie, num_pcie);
95     	fill_ddi_descriptors(scfg, fsp_ddi, num_ddi);
96     }
97     
98     static void fsp_usb_oem_customization(FSP_S_CONFIG *scfg,
99     			const struct soc_amd_picasso_config *cfg)

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...