[PATCH] libpayload: make cursor position available to payloads

[Stefan Reinauer]

see patch...

libpayload: make cursor position available to payloads

[Jordan Crouse]

On 11/08/08 15:48 +0200, Stefan Reinauer wrote:
> see patch...
> make cursor position available to payloads
>
> Signed-off-by: Stefan Reinauer
> Index: include/libpayload.h
>
> --- include/libpayload.h	(revision 425)
> +++ include/libpayload.h	(working copy)
> @@ -123,6 +123,7 @@
>  void video_console_putc(u8 row, u8 col, unsigned int ch);
>  void video_console_clear(void);
>  void video_console_cursor_enable(int state);
> +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en);
>
> /* drivers/option.c */
>  int get_option(void *dest, char *name);
> Index: drivers/video/video.c
> ===================================================================
> --- drivers/video/video.c	(revision 425)
> +++ drivers/video/video.c	(working copy)
> @@ -140,6 +140,12 @@
>    video_console_fixup_cursor();
>  }
>
> +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en)
> +{
> if (console->get_cursor)
> console->get_cursor(&cursorx, &cursory, &cursor_enabled);

Oops - I think you forgot to rename some variables here.
Also, you might want to set the return values to zero if console->get_cursor
doesn't exist.

Jordan

libpayload: make cursor position available to payloads

[Stefan Reinauer]

Jordan Crouse wrote:
> > +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en)
> > +{
> > if (console->get_cursor)
> > console->get_cursor(&cursorx, &cursory, &cursor_enabled);
>
> Oops - I think you forgot to rename some variables here.
> Also, you might want to set the return values to zero if console->get_cursor
> doesn't exist.

d'uh.. of course.

libpayload: make cursor position available to payloads

[Peter Stuge]

Stefan Reinauer wrote:
> +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en)
> +{
> *x=0;
> *y=0;
> *en=0;
> if (console->get_cursor)
> console->get_cursor(x, y, en);
>
> +}

Make the above if (console && console->get_cursor) and it's:

Acked-by: Peter Stuge