[PATCH]RCA RM4100 and Thomson IP1000 auto.c rework

[Joseph Smith]

Hello,
This is a rework patch for the RCA RM4100 and Thomson IP1000. A few of 
the changes include:

1. Setting up the PCI Host Bridge registers (not doing this was causing 
random unexpected exception errors)

2. Setting up some LPC registers

3. dropping the early lpc code to disable the TCO timer. This probably 
can also be dropped from the i82801xx code too. To my suprise the is an 
LPC register that disables this completely (0xd4).

4. move gpio code to run earlier.

5. all this needs to be done pre-raminit

Build and Run tested. See patch.

Signed-off-by: Joseph Smith

[Joseph Smith]

On 01/29/2010 01:46 PM, Joseph Smith wrote:
> Hello,
> This is a rework patch for the RCA RM4100 and Thomson IP1000. A few of
> the changes include:
> Setting up the PCI Host Bridge registers (not doing this was causing
>
> random unexpected exception errors)
>
> Setting up some LPC registers
>
> dropping the early lpc code to disable the TCO timer. This probably
>
> can also be dropped from the i82801xx code too. To my suprise the is an
> LPC register that disables this completely (0xd4).
>
> move gpio code to run earlier.
>
> all this needs to be done pre-raminit
>
> Build and Run tested. See patch.
>
> Signed-off-by: Joseph Smith

Oh, by the way, I just wanted to give a big shout to SerialICE for 
providing this information :-O

[ron minnich]

Acked-by: Ronald G. Minnich

[Joseph Smith]

On 01/29/2010 02:05 PM, ron minnich wrote:
> Acked-by: Ronald G. Minnich

Thanks r5064

[Carl-Daniel Hailfinger]

On 29.01.2010 19:46, Joseph Smith wrote:
> This is a rework patch for the RCA RM4100 and Thomson IP1000.
> Index: src/mainboard/thomson/ip1000/auto.c
> ===================================================================
> --- src/mainboard/thomson/ip1000/auto.c	(revision 5063)
> +++ src/mainboard/thomson/ip1000/auto.c	(working copy)
> @@ -1,7 +1,7 @@
>  /*
> This file is part of the coreboot project.
> Copyright (C) 2008 Joseph Smith
> Copyright (C) 2010 Joseph Smith
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by

IANAL, but I think that legal requirements say you should never remove
old copyright entries unless all of the code has been replaced. In this
case, one of the following lines would probably be appropriate:

Copyright (C) 2008,2010 Joseph Smith 
Copyright (C) 2008-2010 Joseph Smith

Regards,
Carl-Daniel

[Joseph Smith]

On 01/30/2010 08:56 AM, Carl-Daniel Hailfinger wrote:
> On 29.01.2010 19:46, Joseph Smith wrote:
> > This is a rework patch for the RCA RM4100 and Thomson IP1000.
> > Index: src/mainboard/thomson/ip1000/auto.c
> > ===================================================================
> > --- src/mainboard/thomson/ip1000/auto.c	(revision 5063)
> > +++ src/mainboard/thomson/ip1000/auto.c	(working copy)
> > @@ -1,7 +1,7 @@
> >   /*
> > This file is part of the coreboot project.
> > Copyright (C) 2008 Joseph Smith
> > Copyright (C) 2010 Joseph Smith
> > This program is free software; you can redistribute it and/or modify
> > it under the terms of the GNU General Public License as published by
>
> IANAL, but I think that legal requirements say you should never remove
> old copyright entries unless all of the code has been replaced. In this
> case, one of the following lines would probably be appropriate:
>
> Copyright (C) 2008,2010 Joseph Smith
> Copyright (C) 2008-2010 Joseph Smith

I would understand if you changed someone else, but I don't think there 
is anything worng with updateing your own info?

[Joseph Smith]

On 01/30/2010 08:56 AM, Carl-Daniel Hailfinger wrote:
> On 29.01.2010 19:46, Joseph Smith wrote:
> > This is a rework patch for the RCA RM4100 and Thomson IP1000.
> > Index: src/mainboard/thomson/ip1000/auto.c
> > ===================================================================
> > --- src/mainboard/thomson/ip1000/auto.c	(revision 5063)
> > +++ src/mainboard/thomson/ip1000/auto.c	(working copy)
> > @@ -1,7 +1,7 @@
> >   /*
> > This file is part of the coreboot project.
> > Copyright (C) 2008 Joseph Smith
> > Copyright (C) 2010 Joseph Smith
> > This program is free software; you can redistribute it and/or modify
> > it under the terms of the GNU General Public License as published by
>
> IANAL, but I think that legal requirements say you should never remove
> old copyright entries unless all of the code has been replaced. In this
> case, one of the following lines would probably be appropriate:
>
> Copyright (C) 2008,2010 Joseph Smith
> Copyright (C) 2008-2010 Joseph Smith

ok fixed.