New patch to review for coreboot: 1829cdf Sandybridge: Fix integer overrun in romstage udelay()

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1412

-gerrit

commit 1829cdfcb84662a78320b1979cb6e3b3ec2f28f6
Author: Stefan Reinauer 
Date:   Wed Jul 25 16:15:25 2012 -0700

Sandybridge: Fix integer overrun in romstage udelay()

This was broken, fixing according to related patch for i945

Change-Id: I925cd205ee5beb918181740a7b981a4209688ac6
    Signed-off-by: Stefan Reinauer 
---
 src/northbridge/intel/sandybridge/udelay.c |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/udelay.c b/src/northbridge/intel/sandybridge/udelay.c
index 3d8ba96..2e795c7 100644
--- a/src/northbridge/intel/sandybridge/udelay.c
+++ b/src/northbridge/intel/sandybridge/udelay.c
@@ -23,9 +23,20 @@
 #include <cpu/x86/msr.h>

/**
- * Intel Core(tm) cpus always run the TSC at the maximum possible CPU clock
+ * Intel SandyBridge/IvyBridge CPUs always run the TSC at BCLK=100MHz
  */

+/* Simple 32- to 64-bit multiplication. Uses 16-bit words to avoid overflow. */
+static inline void multiply_to_tsc(tsc_t *const tsc, const u32 a, const u32 b)
+{
+	tsc->lo = (a & 0xffff) * (b & 0xffff);
+	tsc->hi = ((tsc->lo >> 16)
+		+ ((a & 0xffff) * (b >> 16))
+		+ ((b & 0xffff) * (a >> 16)));
+	tsc->lo = ((tsc->hi & 0xffff) << 16) | (tsc->lo & 0xffff);
+	tsc->hi = ((a >> 16) * (b >> 16)) + (tsc->hi >> 16);
+}
+
 void udelay(u32 us)
 {
    u32 dword;
@@ -33,15 +44,12 @@ void udelay(u32 us)
    msr_t msr;
    u32 fsb = 100, divisor;
    u32 d;			/* ticks per us */
-	u32 dn = 0x1000000 / 2;	/* how many us before we need to use hi */

msr = rdmsr(0xce);
    divisor = (msr.lo >> 8) & 0xff;

-	d = fsb * divisor;
-
-	tscd.hi = us / dn;
-	tscd.lo = (us - tscd.hi * dn) * d;
+	d = fsb * divisor; /* On Core/Core2 this is divided by 4 */
+	multiply_to_tsc(&tscd, us, d);

tsc1 = rdtsc();
    dword = tsc1.lo + tscd.lo;