Hi,
attached patch adds code to create bus entries in the mptable from the device tree instead of the hardcodes we do right now.
It also changes kontron/986lcd-m to use the new function, where its advantage is starting to show: As we support a given riser card (with pci bridge and bus), we currently have to look for the card and add a bus and interrupt sources to the mptable. With this patch, the bus is automatically added to the table. Once interrupt sources are handled the same way, that special case could be dropped completely (and such plug-in cards that add buses will be properly supported on all boards)
I didn't adapt all the mptable.c files in the tree, as I feel the code should be tested on a more diverse set of boards. Our table generation code sometimes differs only so slightly, and I don't know in all cases if the automatic handling would pick up those differences, or if they actually matter (or are correct in the first place).
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Patrick Georgi wrote:
attached patch adds code to create bus entries in the mptable from the device tree instead of the hardcodes we do right now.
\o/
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Acked-by: Peter Stuge peter@stuge.se
I think it would be great to write a few lines about what changes need to be made for boards to use this. Maybe on the wiki?
//Peter
Am 25.06.2010 15:23, schrieb Peter Stuge:
Acked-by: Peter Stuge peter@stuge.se
Committed as r5647
I think it would be great to write a few lines about what changes need to be made for boards to use this. Maybe on the wiki?
I was thinking of adding this to http://www.coreboot.org/Flag_Days The main difference to the existing documentation on that page is that it is about changes that were implemented across the entire tree. This change only affects a single board so far.
I'll do it this way: A Flag_Days entry now, documenting the new function and how to migrate boards. Another Flag_Days entry once all upstream boards are migrated, while making smp_write_bus (the "plumbing" function used for this) static (ie. private)
Patrick