Re: [coreboot] r3401 - trunk/util/flashrom

[Carl-Daniel Hailfinger]

On 01.07.2008 01:45, [e-mail] wrote:
> Author: stepan
> Date: 2008-07-01 01:45:22 +0200 (Tue, 01 Jul 2008)
> New Revision: 3401
>
> Modified:
>    trunk/util/flashrom/chipset_enable.c
>    trunk/util/flashrom/flash.h
>    trunk/util/flashrom/ichspi.c
>    trunk/util/flashrom/it87spi.c
>    trunk/util/flashrom/spi.c
> Log:
> First attempt to clean up SPI probing and create a common
> construct: the flash bus.
>
> At some point the flash bus will be part of struct flashchip.
>
> Pardon me for pushing this in, but I think it is important to beware of further
> decay and it will improve things for other developers in the short run.
>
> Carl-Daniel, I will consider your suggestions in another patch. I want to keep
> things from getting too much for now. The patch includes Rudolf's VIA SPI
> changes though.

OK with me. I assume you have tested the code.
> Signed-off-by: Stefan Reinauer 
> Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel