resubmit - patch for Win Enterprises PL-6064/65 support

[Anish Patel]

see attached.
---

resubmit - patch for Win Enterprises PL-6064/65 support

[Joseph Smith]

On Thu, 11 Feb 2010 16:26:36 -0500, Anish Patel
 wrote:
> see attached.

Hello, could anyone with Geode LX experience please take a look at this?

resubmit - patch for Win Enterprises PL-6064/65 support

[ron minnich]

I'm ok with most of it but this part worries me:
+
+initobj-y += crt0.o
+crt0s := $(src)/cpu/x86/16bit/entry16.inc
+crt0s += $(src)/cpu/x86/32bit/entry32.inc
+crt0s += $(src)/cpu/x86/16bit/reset16.inc
+crt0s += $(src)/arch/i386/lib/id.inc
+crt0s += $(src)/cpu/amd/model_lx/cache_as_ram.inc
+crt0s += $(obj)/mainboard/$(MAINBOARDDIR)/romstage.inc
+
+ldscripts := $(src)/arch/i386/init/ldscript_fallback_cbfs.lb
+ldscripts += $(src)/cpu/x86/16bit/entry16.lds
+ldscripts += $(src)/cpu/x86/16bit/reset16.lds
+ldscripts += $(src)/arch/i386/lib/id.lds
+ldscripts += $(src)/arch/i386/lib/failover.lds

I thought we were trying to get away from this kind of thing. Why is
it still there?

ron

resubmit - patch for Win Enterprises PL-6064/65 support

[Anish Patel]

I didn't know any better.... i was going off the amd db800....
i'll update this soon.

On 02/11/10 18:25, ron minnich wrote:
> I'm ok with most of it but this part worries me:
>
> +initobj-y += crt0.o
> +crt0s := $(src)/cpu/x86/16bit/entry16.inc
> +crt0s += $(src)/cpu/x86/32bit/entry32.inc
> +crt0s += $(src)/cpu/x86/16bit/reset16.inc
> +crt0s += $(src)/arch/i386/lib/id.inc
> +crt0s += $(src)/cpu/amd/model_lx/cache_as_ram.inc
> +crt0s += $(obj)/mainboard/$(MAINBOARDDIR)/romstage.inc
>
> +ldscripts := $(src)/arch/i386/init/ldscript_fallback_cbfs.lb
> +ldscripts += $(src)/cpu/x86/16bit/entry16.lds
> +ldscripts += $(src)/cpu/x86/16bit/reset16.lds
> +ldscripts += $(src)/arch/i386/lib/id.lds
> +ldscripts += $(src)/arch/i386/lib/failover.lds
>
> I thought we were trying to get away from this kind of thing. Why is
> it still there?
>
> ron

resubmit - patch for Win Enterprises PL-6064/65 support

[Anish Patel]

actually, could someone point me toward a newer Makefile.inc??

On 02/11/10 18:25, ron minnich wrote:
> I'm ok with most of it but this part worries me:
>
> +initobj-y += crt0.o
> +crt0s := $(src)/cpu/x86/16bit/entry16.inc
> +crt0s += $(src)/cpu/x86/32bit/entry32.inc
> +crt0s += $(src)/cpu/x86/16bit/reset16.inc
> +crt0s += $(src)/arch/i386/lib/id.inc
> +crt0s += $(src)/cpu/amd/model_lx/cache_as_ram.inc
> +crt0s += $(obj)/mainboard/$(MAINBOARDDIR)/romstage.inc
>
> +ldscripts := $(src)/arch/i386/init/ldscript_fallback_cbfs.lb
> +ldscripts += $(src)/cpu/x86/16bit/entry16.lds
> +ldscripts += $(src)/cpu/x86/16bit/reset16.lds
> +ldscripts += $(src)/arch/i386/lib/id.lds
> +ldscripts += $(src)/arch/i386/lib/failover.lds
>
> I thought we were trying to get away from this kind of thing. Why is
> it still there?
>
> ron

resubmit - patch for Win Enterprises PL-6064/65 support

[ron minnich]

src/mainboard/dell/s1850/Makefile.inc

This includes the generic Makefile. I just looked at it and much to my
surprise we still have all the fiddly includes -- we tried get rid of
those last june but I guess we did not get done.

I'd sure like to see all that reduced to one or two included .lds and
.inc files. I found it hard to track.

thanks

ron

resubmit - patch for Win Enterprises PL-6064/65 support

[Patrick Georgi]

Am 12.02.2010 00:25, schrieb ron minnich:
> I thought we were trying to get away from this kind of thing. Why is
> it still there?

Not quite there yet. I'll handle all boards that are in the tree when I
get to removing that.

Patrick

resubmit - patch for Win Enterprises PL-6064/65 support

[Edwin Beasant]

Patch looks good (excluding comments already made), with one side thought:
Looks like the UARTS are on the SuperIo device, a-la db800, but there no call to disable_internal_uarts?
It may be a nicety, but it stops any potential issues with early debug?
Cheers,
Edwin

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On Behalf Of Patrick Georgi
Sent: 12 February 2010 08:15
To: [e-mail]
Subject: Re: [coreboot] resubmit - patch for Win Enterprises PL-6064/65 support

Am 12.02.2010 00:25, schrieb ron minnich:
> I thought we were trying to get away from this kind of thing. Why is
> it still there?

Not quite there yet. I'll handle all boards that are in the tree when I
get to removing that.

Patrick