Re: [coreboot] I can not add FILO as a payload

[Peter Stuge]

ali hagigat wrote:
> cd payloads/libpayload/
> /root/bios/coreboot/payloads/libpayload> make defconfig
> /root/bios/coreboot/payloads/libpayload> make
> /root/bios/coreboot/payloads/libpayload> make DESTDIR=../filo/build install
> /root/bios/coreboot/payloads/libpayload> cd ../filo
> /root/bios/coreboot/payloads/filo> make menuconfig

So far so good.
> /root/bios/coreboot/payloads/filo> make

..
> CC      build/fs/cbfs.o
> /root/bios/coreboot/payloads/filo/fs/cbfs.c:113:20: error: conflicting types for 'cbfs_find_file'
> /root/bios/coreboot/payloads/filo/build/libpayload/include/cbfs_core.h:175:7: note: previous declaration of 'cbfs_find_file' was here
> make: *** [/root/bios/coreboot/payloads/filo/build/fs/cbfs.o] Error 1

..
> What caused the problem then?

Look more closely at the error message. It is actually a very clear
error message. Then you look at the source code pointed to by the
error message.

This process is the *very first* problem resolution process that
*every* programmer in this world encounters. It is amazing that you
seem to not know it. :\

FILO is probably not quite up to date with the latest libpayload API,
so you now have an opportunity to fix this and make FILO better for
everyone.

//Peter

I can not add FILO as a payload

[ali hagigat]

Hello Peter. Thank you very much for the reply. I have just copied
part of README file from the Coreboot project:

/root> cat ~/bios/coreboot/payloads/filo/README
BUG REPORTING

If you have problem with FILO, set DEBUG_ALL in Config and send its
console output to the coreboot mailinglist at .

So i did:

/root/bios/coreboot/payloads/filo> make
Found Libpayload
/root/bios/coreboot/payloads/filo/build/libpayload/lib/libpayload.a.
  CC      build/i386/context.o
  CC      build/i386/segment.o
  CC      build/i386/timer.o
  CC      build/i386/sys_info.o
  CC      build/i386/linux_load.o
  CC      build/main/filo.o
  CC      build/main/strtox.o
  CC      build/main/elfload.o
  CC      build/main/ipchecksum.o
  CC      build/fs/blockdev.o
  CC      build/fs/vfs.o
  CC      build/fs/eltorito.o
  CC      build/fs/fsys_ext2fs.o
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c: In function 'dump_super':
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:404:33: error:
'struct ext2_super_block' has no member named 's_log_frag_size'
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:406:26: error:
'struct ext2_super_block' has no member named 's_frags_per_group'
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c: At top level:
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:411:24: warning:
'struct ext2_group_desc' declared inside parameter list [enabled by
default]
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:411:24: warning:
its scope is only this definition or declaration, which is probably
not what you want [enabled by default]
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c: In function
'dump_group_desc':
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:414:35: error:
dereferencing pointer to incomplete type
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:415:35: error:
dereferencing pointer to incomplete type
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:416:34: error:
dereferencing pointer to incomplete type
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:417:32: error:
dereferencing pointer to incomplete type
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:418:34: error:
dereferencing pointer to incomplete type
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:419:32: error:
dereferencing pointer to incomplete type
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c: In function
'ext4fs_block_map':
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:640:18: error:
conflicting types for 'i'
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:637:7: note:
previous declaration of 'i' was here
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c: In function 'ext2fs_dir':
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:861:23: warning:
passing argument 1 of 'dump_group_desc' from incompatible pointer type
[enabled by default]
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:411:1: note:
expected 'struct ext2_group_desc *' but argument is of type 'struct
ext2_group_desc *'
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:877:3: error: 'gdp'
undeclared (first use in this function)
/root/bios/coreboot/payloads/filo/fs/fsys_ext2fs.c:877:3: note: each
undeclared identifier is reported only once for each function it
appears in
make: *** [/root/bios/coreboot/payloads/filo/build/fs/fsys_ext2fs.o] Error 1

I lack time but I will try to get it fixed. I hope so.

Regards.

On Tue, Feb 7, 2012 at 5:45 PM, Peter Stuge  wrote:
> ali hagigat wrote:
> > cd payloads/libpayload/
> > /root/bios/coreboot/payloads/libpayload> make defconfig
> > /root/bios/coreboot/payloads/libpayload> make
> > /root/bios/coreboot/payloads/libpayload> make DESTDIR=../filo/build install
> > /root/bios/coreboot/payloads/libpayload> cd ../filo
> > /root/bios/coreboot/payloads/filo> make menuconfig
>
> So far so good.
> > /root/bios/coreboot/payloads/filo> make
>
> ..
> > CC      build/fs/cbfs.o
> > /root/bios/coreboot/payloads/filo/fs/cbfs.c:113:20: error: conflicting types for 'cbfs_find_file'
> > /root/bios/coreboot/payloads/filo/build/libpayload/include/cbfs_core.h:175:7: note: previous declaration of 'cbfs_find_file' was here
> > make: *** [/root/bios/coreboot/payloads/filo/build/fs/cbfs.o] Error 1
>
> ..
> > What caused the problem then?
>
> Look more closely at the error message. It is actually a very clear
> error message. Then you look at the source code pointed to by the
> error message.
>
> This process is the *very first* problem resolution process that
> *every* programmer in this world encounters. It is amazing that you
> seem to not know it. :\
>
> FILO is probably not quite up to date with the latest libpayload API,
> so you now have an opportunity to fix this and make FILO better for
> everyone.
>
> //Peter