, Hi guys,
First off, I'm still looking for testers for my early CBMEM work on 440BX mainboards. [1] I've actually added asus/p2b-ds to the mix [2] but because of a previously documented issue I'm not able to get a complete board_status report, so again more testing help is appreciated.
Meanwhile, I moved to adding ACPI support to these boards and pushed a series of 3 patches for review, together they form a complete ACPI DSDT coding for my asus/p2b-ls board, built from a remix of ACPI stuff found in asus/p2b and elsewhere in tree and the DSDT extracted from factory bios. I'll need this in place before I can make soft-off and suspend/resume work.
https://review.coreboot.org/c/21670/ https://review.coreboot.org/c/21671/ https://review.coreboot.org/c/21672/
I did check the contents against the DSDT table extracted from OEM BIOS and have adapted these to reuse as much in-tree ACPI stuff as possible, and they are written with reuse and sharing in mind. They haven't been boot tested yet, but I wanted to throw this out here as this is my first real ACPI work and there must be something wrong in there, so please whip me softly if you have to. :) All I have achieved at this stage is that the DSDT compiles without errors, but there are still warnings so I can use some help clearing them as well.
Thanks again Keith
[1] https://mail.coreboot.org/pipermail/coreboot/2017-September/085116.html [2] https://review.coreboot.org/c/21646/
ps. There was only ACPI 1.0 when these boards were released. pps. The patch broke asus/p2b. But "make what-jenkins-does" didn't catch it. I'd expect it to literally do exactly as what Jenkins does and catch the breakage. Or do I need to go back to abuild?
-
Keith Hui